add output_dir feature #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review this pr :) |
|
@ilev4ik please don't mention people who don't even have the permissions to merge your PR (i.e. me, probably some others). FYI I suspect there's a chance this project will no longer be maintained now that Hedron Vision was acquired, though I have no inside information. |
|
@garymm how can I check if you have a permission or not? I relied on autocomplete when mentioning. It seems it was a mistake My apologises for inconvenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about to provide a support of writing out compile_commands.json relatively to workspace root to provide each project means of customizing their .clangd.
By default compile-commands-extractor's refresh_compile_command produces its output into bazel-workspace root. But our monorepository is single-rooted workspace and has many subprojects as children folders. Multiple projects are maintained by one team of developers, but a single project may have its own clangd configuration.
I didn't find any customization attribute of bazel target so created this PR. If there exist any please let me know. TY
@cpsauer it would be great if you find some time to review PR :)
Closes #217