feat: parse .terraform-version files for stacks dirs #1746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EventBus has a fixed list of topics that anyone can subscribe to. Whenever an event is published on a topic, all subscribers are notified.
This moves all logic related to Terraform root modules into a feature. The feature keeps track of installed providers and modules.
This moves all logic related to module files into a feature. The feature contains all state, jobs, hooks, and decoder related files.
This moves all logic related to Terraform's variable definition files into a feature.
All jobs are now scheduled from their respective feature. There is no need for a separate indexer anymore.
The hooks are only relevant inside the modules feature and have been moved into the feature.
We don't schedule any jobs when walking a workspace for the first time, so the walker only needs to report directories and their files via discover events.
This better reflects the new structure as the walker only walks directories and fires events now. The state is managed in the separate features after they get a discover event.
All parsing related logic has been moved to the specific features. All job implementations now live in their respective features as well.
The global decoder now only acts as a "proxy" and will use a more specific decoder from a feature depending on the language ID.
The state has been moved to separate features. The global state now only contains entities that are relevant to everything. The new change tracking has been partially lifted into the features and only the generic part is kept in the global state.
We keep track of all features in this central location. This should be the main place you need to extend whenever a new feature is introduced.
Document synchronization handlers will now fire an event for every incoming request. Features can subscribe to these events. Language feature handlers will now wait for running jobs for a directory before attempting to complete the request and return data.
* Update changelog * Update VERSION
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
ansgarm
commented
Jul 2, 2024
dbanck
force-pushed
the
stacks_static_schema
branch
2 times, most recently
from
2ed3e9f to
2bcbad8
Compare
|
superseded by #1756 (rebasing hell, yay) |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open