Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NixOS revision not showing in boot loader or nixos-version #149

Open
madjam002 opened this issue Jul 6, 2024 · 3 comments
Open

NixOS revision not showing in boot loader or nixos-version #149

madjam002 opened this issue Jul 6, 2024 · 3 comments

Comments

@madjam002
Copy link

Since 24.05 I've noticed that the NixOS version just shows as pre-git, removing lib here seems to fix it, but might break some things when patching Nixpkgs?

diff --git a/lib/mkFlake.nix b/lib/mkFlake.nix
index 5925b77..8a43746 100644
--- a/lib/mkFlake.nix
+++ b/lib/mkFlake.nix
@@ -188,7 +188,7 @@ let
         inherit inputs;
         pkgs = selectedNixpkgs;
       }) // (optionalAttrs (host.output == "nixosConfigurations") {
-        inherit lib baseModules;
+        inherit baseModules;
         specialArgs = nixosSpecialArgs // specialArgs;
       }));
     }
@gytis-ivaskevicius
Copy link
Owner

how does this impact nixos version? 🤔 This seems odd, I should dig through the code

@madjam002
Copy link
Author

I'm really not sure to be honest, I just noticed this behaviour started from 24.05 onwards, but it didn't happen on another one of my repositories which doesn't use flake-utils-plus, so I started digging around and after making the change above it fixed the issue for me.

@Tanish2002
Copy link

can confirm happening to me as well.

found this thread (similar issue without using fup): here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants