diff --git a/packages/webpack-module-federation/tests/areModulesReady.test.tsx b/packages/webpack-module-federation/tests/areModulesReady.test.tsx index 18df81c8c..54aa0f3ab 100644 --- a/packages/webpack-module-federation/tests/areModulesReady.test.tsx +++ b/packages/webpack-module-federation/tests/areModulesReady.test.tsx @@ -26,12 +26,6 @@ class DummyRuntime extends AbstractRuntime { const runtime = new DummyRuntime(); -/* -- when local module deferred registrations and remote module deferred registrations are registered and only the local module deferred registrations are completed, return false -- when local module deferred registrations and remote module deferred registrations are registered and only the remote module deferred registrations are completed, return false - -*/ - test("when no modules are registered, return false", async () => { const localModuleRegistry = new LocalModuleRegistry(); diff --git a/samples/endpoints/shell/src/AppRouter.tsx b/samples/endpoints/shell/src/AppRouter.tsx index cb8efab6b..7d5a5da70 100644 --- a/samples/endpoints/shell/src/AppRouter.tsx +++ b/samples/endpoints/shell/src/AppRouter.tsx @@ -6,41 +6,6 @@ import axios from "axios"; import { useEffect, useMemo, useState } from "react"; import { Outlet, RouterProvider, createBrowserRouter, useLocation } from "react-router-dom"; -/* -AppRouter - - loader - - onFetchInitialData -> (doit passer un "signal") - - onFetchSession - - onFetchProtectedData -> Si fournie, est inclus dans le isReady - (doit passer un "signal") - - waitForMsw - - rootRoute - Si fournis est-ce le parent de la root route du AppRouter? - - routerProviderOptions -*/ - -/* - -import { AppRouter as SquideAppRouter } from "@squide/shell"; - -export function AppRouter() { - const [subscription, setSubscription] = useState(); - - onFetchProtectedData() { - .... - - - } - - return ( - - - - - ) -} - -*/ - async function fetchPublicData( setFeatureFlags: (featureFlags: FeatureFlags) => void, logger: Logger