Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native custom token symbol not recognized correctly #211

Open
trungtt198x opened this issue Jul 11, 2018 · 3 comments
Open

Native custom token symbol not recognized correctly #211

trungtt198x opened this issue Jul 11, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@trungtt198x
Copy link

screen shot 2018-07-11 at 11 48 56 pm

I've built the EOSIO source code with a pre-defined native token symbol by using the following cmd:
./eosio_build.sh -s FST

The option -s enables to change to a new native token symbol.

Everything works fine and I can also create accounts staked with the newly-defined native token symbol.

However, from the attached screenshot, clearly to see that your wallet has some bug that it still displays the 'EOS' symbol for the "Delegated" part.

I've looked into your wallet source code and have found out that, in the file eos-voter-wallet/app/shared/utils/StatsFetcher.js, at line 121 and 122 (master branch):

      cpuWeight: `${totalCpuAmount.minus(selfCpuAmount).toFixed(4)} EOS`,
      netWeight: `${totalNetAmount.minus(selfNetAmount).toFixed(4)} EOS`,

You still hard-code the EOS symbol, right?

I very love your nice wallet and look forward to your fix soon.
Thanks

@aaroncox
Copy link
Member

Yeah we do have a few places that we hardcoded the EOS symbol.

We will go through and replace those with the detected base currency in one of the upcoming builds.

@aaroncox aaroncox added the enhancement New feature or request label Jul 11, 2018
@trungtt198x
Copy link
Author

@aaroncox
Many thanks.
Please notify me when you release the fix for this bug.

@Lostrishs
Copy link

@aaroncox Hi! See the problem like this one right now when trying to get back the delegated resources.
image

Don't really sure it is needed to open a new issue. If so - I will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants