-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[teleport-update] Adjustments for SELinux #51474
Open
sclevine
wants to merge
6
commits into
master
Choose a base branch
from
sclevine/autoupdates-selinux
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verified on RHEL 9.5
|
sclevine
force-pushed
the
sclevine/autoupdates-selinux
branch
from
January 24, 2025 23:04
be9e382
to
ae0889e
Compare
sclevine
added
no-changelog
Indicates that a PR does not require a changelog entry
teleport-update
labels
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts
teleport-update
to avoid issues with default SELinux configuration.These changes are based on research and testing by @vapopov.
When service files are copied atomically using renameio, the initial temporary location adds SELinux contexts that make the file unreadable by systemctl:
This PR adjusts renameio to use the same target directory when this is relevant:
These temporarily files are created in the format
/etc/systemd/system/.teleport.service1234
. This does not appear to interfere with systemd or systemctl.This PR also adds various checks to make sure that the systemd service file is readable during initial install and update.
The
teleport-update
binary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/opt/teleport
.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289