-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded camera in preprocess/prepare_chunk.py causes error #90
Comments
Hi, |
Thanks for your response! It throws the ExistCamera() error and does that for every raw chunk (they are created, so the make_chunk.py script works fine) It fails consistently every time the camera with id 1 is not detected during colmap, so it is not shown in rectified folder and in the database too. I have actually modified fill_database.py to print the camera id that it finds in the database and used it in prepare_chunk.py, which solved the problem. As for the existing_camera_id being bool, I may be wrong, but in the same lines of colmap code I referenced the existing_camera_id parameter is casted to camera_t which is uint32_t and not boolean (https://github.com/colmap/colmap/blob/main/src/colmap/util/types.h#L80) Please, correct me if I'm mistaken |
You are right, the parameter description I found was misleading. Thank you for pointing this out. This means that our preprocessing pipeline needs some fixing. In the meantime, the initial feature extraction parameter should be |
I can commit my workaround solution consisting of a few lines of extra code that jsut grabs first camera that the database has, so its guaranteed to work as long as you have any cameras |
I already updated generate_colmap.py. Yes, all cameras should share intrinsic and our gopros are very similar. |
Hey, thanks for the great work!
I have a reconstruction, which fails during chunking stage. to be exact it fails at this code (prepare_chunk.py, line 75)
print("extracting features...") colmap_feature_extractor_args = [ colmap_exe, "feature_extractor", "--database_path", f"{bundle_adj_chunk}/database.db", "--image_path", f"{bundle_adj_chunk}/images", "--ImageReader.existing_camera_id", "1", ]
I was using 6 cameras, but inspecting the undistorted images showed, that the colmap managed to reconstruct only cam3.
Colmap throws error ExistsCamera, which seems logical, as there is only camera 3, but there is hardcoded --ImageReader.existing_camera_id 1
Am I understanding this correctly, and if so:
Thanks in advance
The text was updated successfully, but these errors were encountered: