Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginAppClientSecret not set in config #5202

Open
Rulasmur opened this issue Oct 23, 2024 · 10 comments
Open

PluginAppClientSecret not set in config #5202

Rulasmur opened this issue Oct 23, 2024 · 10 comments
Labels

Comments

@Rulasmur
Copy link

What went wrong?

What happened:

  • Fresh install of everything, ran the curls per the README.
  • /api/plugins/grafana-oncall-app/resources/plugin/status returns PluginAppClientSecret not set in config

What did you expect to happen:

  • Oncall to create it's Service account

Image

How do we reproduce it?

  1. Fresh install of Grafana and oncall
  2. follow README
  3. Check status api

Grafana OnCall Version

1.11.3

Product Area

Other

Grafana OnCall Platform?

Docker

User's Browser?

No response

Anything else to add?

No response

@Rulasmur Rulasmur added the bug Something isn't working label Oct 23, 2024
@kosfango
Copy link

The same issue with standalone grafana latest and oncall plugin latest
logger=plugin.grafana-oncall-app t=2024-10-23T19:36:10.084977473Z level=error msg="Error getting settings from context" error="PluginAppClientSecret not set in config"

@Rulasmur
Copy link
Author

I have been able to confirm that downgrading grafana to 11.2.3 fixes the issue

@daniel-boman
Copy link

This also affects existing Grafana installations recently upgraded to v11.3, rendering OnCall unable to be viewed from Grafana.

@VermiumSifell
Copy link

It looks like if I remove the service account it doesn't create a new one on Grafana v11.3. But if I downgrade to v11.2.3 is does create the service account.

I uninstalled plugin, installed it. That's how I checked this.

@bpedersen2
Copy link

see also #5100

@shawlz
Copy link

shawlz commented Dec 19, 2024

I'm running Grafana 11.4.0 and Grafana Oncall Engine 1.13.11 and Grafana OnCall App Plugin 1.13.11 and I had this same error.

The solution in this comment #3761 worked for me

@bck01215
Copy link
Contributor

bck01215 commented Jan 1, 2025

I'm running Grafana 11.4.0 and Grafana Oncall Engine 1.13.11 and Grafana OnCall App Plugin 1.13.11 and I had this same error.

The solution in this comment #3761 worked for me

Still experiencing the issue when upgrading. Running in k8s using OSS and 2 replicas

@kko72
Copy link

kko72 commented Jan 16, 2025

I ran into the same problem, and the solution is given here: #5100
Ensuring that in the grafana.ini these feature_toggles are set:

[feature_toggles]
accessControlOnCall = false
enable = externalServiceAccounts

and that the grafana container has the following environment variable:

GF_AUTH_MANAGED_SERVICE_ACCOUNTS_ENABLED=true

fixed it for me.

This is also what has been done in this commit

@senpro-ingwersenk
Copy link

Why is it always OnCall that requires so many dumb workarounds?...

I use Kubernetes and thus configure Grafana entirely through the environment. Any alternative to putting these settings in place?

Thanks!

@zentavr
Copy link

zentavr commented Jan 24, 2025

@senpro-ingwersenk frankly speaking I prefer bitnami charts comparing to grafana's, so I managed that.
I think the approach might be similar:

  • create the config map, like:
    - apiVersion: v1
      kind: ConfigMap
      metadata:
        name: grafana-oncall-plugin-provisioning
      data:
        # ref.: https://github.com/grafana/oncall/issues/4829#issuecomment-2567046523
        # stackid should be set to 5 and orgid 100 for all self hosted instances
        grafana-oncall-app.yaml: |
          apiVersion: 1
          
          apps:
            - type: grafana-oncall-app
              name: grafana-oncall-app
              disabled: false
              jsonData:
                stackId: 5
                orgId: 100
                onCallApiUrl: http://grafana-oncall-engine:8080
                #grafanaUrl: http://grafana:3000
    
  • then mount that into grafana container to ...conf/provisioning/plugins/grafana-oncall-app.yaml with extravolumes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants