You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we're using MobX v5.13.0. We should bump the version to latest stable which is 6.12.0. Thanks to it we will be able to use makeAutoObservable and as a result:
remove a lot of decorators from the code (with makeAutoObservable every class method is an action by default, every setter is a computed, every other property is an observable
remove a lot of this bindings because this will be automatically bound to the store class
identify and get rid of updating observable without an action. In new version every case like that will be logged in the console so we need to fix all such places. Using actions has benefits including performance so it will have a positive impact on the app itself
The text was updated successfully, but these errors were encountered:
# What this PR does
- update
"mobx" to "6.12.0",
"mobx-react" to "9.1.0",
- add `runInAction` when update observables after async operations
- update babel config and ts config according to the
[guide](https://mobx.js.org/migrating-from-4-or-5.html)
- add `makeObservable(this);` to each model constructor
## Which issue(s) this PR fixes#3453
## Checklist
- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Currently we're using MobX v5.13.0. We should bump the version to latest stable which is 6.12.0. Thanks to it we will be able to use makeAutoObservable and as a result:
makeAutoObservable
every class method is an action by default, every setter is a computed, every other property is an observablethis
bindings becausethis
will be automatically bound to the store classobservable
without anaction
. In new version every case like that will be logged in the console so we need to fix all such places. Using actions has benefits including performance so it will have a positive impact on the app itselfThe text was updated successfully, but these errors were encountered: