Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup error log of frontend unit test runs #3428

Closed
Tracked by #3733
brojd opened this issue Nov 27, 2023 · 0 comments · Fixed by #4167
Closed
Tracked by #3733

Cleanup error log of frontend unit test runs #3428

brojd opened this issue Nov 27, 2023 · 0 comments · Fixed by #4167
Labels
involved:Frontend

Comments

@brojd
Copy link
Contributor

brojd commented Nov 27, 2023 •
edited
Loading

What went wrong?

We have a lot of error logs like those:

console.error
      Error: Not implemented: navigation (except hash changes)
    ...

console.error
    Warning: You called act(async () => ...) without await. This could lead to unexpected testing behaviour, interleaving multiple act calls and mixing their scopes. You should - await act(async () => ...);

We should use async/await correctly and mock location.reload to get rid of them which will make reading tests output easier.

How do we reproduce it?

  1. Go to any tests job like this one: https://github.com/grafana/oncall/actions/runs/6969513303/job/18965614255?pr=3416
  2. Read the output

Grafana OnCall Version

1.3.59

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@brojd brojd self-assigned this Nov 27, 2023
@brojd brojd removed their assignment Feb 19, 2024
@iskhakov iskhakov mentioned this issue Mar 20, 2024
Open
This was referenced Apr 2, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 17, 2024
Cleanup error logs on frontend unit test run (#4167)
92600c0 
# What this PR does

Cleanup error logs on frontend unit test run

## Which issue(s) this PR closes

Closes #3428

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
involved:Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup error logs on frontend unit test run grafana/oncall
1 participant
@brojd