Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin version 4.6.0 compatiblity issues #1935

Closed
CirnoT opened this issue Dec 17, 2024 · 19 comments · Fixed by #1941
Closed

plugin version 4.6.0 compatiblity issues #1935

CirnoT opened this issue Dec 17, 2024 · 19 comments · Fixed by #1941

Comments

@CirnoT
Copy link

CirnoT commented Dec 17, 2024

Describe the bug
Caused by https://github.com/grafana/grafana-zabbix/blob/main/src/datasource/zabbix/connectors/zabbix_api/zabbixAPIConnector.ts#L148

Happens since v4.6.0 whenever dashboard has variable configured to be of Zabbix type. It would seem that population of variables at dashboard load happens before plugin queries (or receives) version information from datasource API, which causes this TypeError, as version is undefined.

Expected behavior
Variables are populated into dashboard at load time properly.

Screenshots
Image
Image
Image

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
v11.4.0 7.0.6 v4.6.0
@Glafkon
Copy link

Glafkon commented Dec 17, 2024

Same issue at a random moment on any dashboard Image

Grafana Zabbix Grafana-Zabbix Plugin
11.4.0 6.4.20 4.6.0

@urbancabin
Copy link

urbancabin commented Dec 17, 2024

Image
Same issue

Grafana Zabbix Grafana-Zabbix Plugin
v11.4.0 7.2.0 v4.6.0

@onlime
Copy link

onlime commented Dec 17, 2024

Same here, thanks for reporting. v4.6.0 rendered my Grafana completely unusable.

Grafana Zabbix Grafana-Zabbix Plugin
v11.4.0 7.0.6 v4.6.0

Had to revert the plugin like this:

$ grafana-cli plugins install alexanderzobnin-zabbix-app 4.5.7

@CompPhy
Copy link

CompPhy commented Dec 17, 2024

Can confirm, seeing this issue on our system as well. Downgrading seems to fix the issue for now.

@Glafkon
Copy link

Glafkon commented Dec 17, 2024

Can confirm, seeing this issue on our system as well. Downgrading seems to fix the issue for now.

Downgrade doesn't help to solve the problem

@isaqueprofeta
Copy link

@yesoreyeram @zoltanbedi @ivanahuckova Another one related to zabbix's API depecated fields.

Looking at the API Docs on changes from 7.0 to 7.2 it seems that the one that got hit here is the "ZBXNEXT-9452 hostgroup.get: Removed support for deprecated parameters monitored_hosts, real_hosts."

The parameter "real_hosts" should be changed to "with_hosts" and is currently used on 3 places on the code, /pkg/zabbix/methods.go, /src/datasource/zabbix/connectors/zabbix_api/zabbixAPIConnector.ts and the test /src/datasource/zabbix/connectors/zabbix_api/zabbixAPIConnector.test.ts

Digging arround a little more, I found out some other issues on deprecated parameters being used:

  • ZBXNEXT-9452 event.get: Removed support for deprecated parameters select_acknowledges, select_alerts.

    • Change from select_acknowledges to selectAcknowledges
    • src/datasource/zabbix/connectors/zabbix_api/zabbixAPIConnector.ts
  • ZBXNEXT-9452 host.get: Removed support for deprecated parameter selectGroups.

    • Change from to selectGroups to selectHostGroups
    • src/datasource/zabbix/connectors/zabbix_api/zabbixAPIConnector.ts

That's what I got so far.

@yesoreyeram
Copy link
Collaborator

Hiya.. we are investigating this and working on a fix. Meantime, you can use older version of the plugin.

@yesoreyeram yesoreyeram moved this to In Progress in OSS Big Tent Dec 17, 2024
@CompPhy
Copy link

CompPhy commented Dec 18, 2024

Can confirm, seeing this issue on our system as well. Downgrading seems to fix the issue for now.

I should have mentioned.... In our case, we are running Zabbix 6.0 on our server instance. This is still a fully supported release for at least a few more months, and will be in extended support until 2027 as per the LTS lifecycle. I suspect some of these API changes are for 7.0+ versions, but I would think that backwards compatibility needs to be considered for this plugin to support older versions correctly.

Yes, we will be upgrading to 7.0 in the coming year, but as many know this isn't always easy or quick for large deployments.

@valecloud
Copy link

same error here

@Bestig
Copy link

Bestig commented Dec 23, 2024

same error here, looking forward to see a fix please
@yesoreyeram

@hvledder
Copy link

And here ...

Grafana Zabbix Grafana-Zabbix plugin
v11.4.0 v7.2.1 v4.6.0

@yesoreyeram
Copy link
Collaborator

Sorry for the delay.. You can expect a new release by 1st week of Jan.

@yesoreyeram yesoreyeram changed the title SceneVariableSet updateAndValidate error TypeError: Invalid version. Must be a string. Got type "undefined". plugin version 4.6.0 compatiblity issues Dec 24, 2024
@hvledder
Copy link

Thanks for letting us know Sriram!

@amirkh067
Copy link

Hello, any update on this? When can we expect an upgrade? It already 6th of Jan, 2025.

@github-project-automation github-project-automation bot moved this from In Progress to Complete in OSS Big Tent Jan 7, 2025
@zoltanbedi
Copy link
Member

4.6.1 is out with the fix. Sorry for the inconvenience.

@hvledder
Copy link

hvledder commented Jan 7, 2025

Thanks for the effort guys!

@davmanz
Copy link

davmanz commented Jan 8, 2025

Same mistake

Image
Image
Image

@isaqueprofeta
Copy link

Same mistake

Image Image Image

Install 4.6.1

@yesoreyeram
Copy link
Collaborator

yesoreyeram commented Jan 8, 2025

If you are using grafana cloud, the plugin backend is yet to be updated. I will update here once the update finished.

Update: Grafana cloud is now updated with plugin version 4.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.