Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard search results should include what folder they belong to. #102

Open
bg451 opened this issue Jul 31, 2020 · 3 comments
Open

Dashboard search results should include what folder they belong to. #102

bg451 opened this issue Jul 31, 2020 · 3 comments

Comments

@bg451
Copy link

bg451 commented Jul 31, 2020

When searching for dashboards, the current API will include information about the dashboard if it belongs to one that is not the "default" folder. This is what the JSON looks like.

{
"id":1,
"uid":"<redacted>",
"title":"Jobs Dashboard",
"uri":"<redacted>",
"url":"/dashboards/d/<redacted>/jobs-dashboard",
"slug":"",
"type":"dash-db",
"tags":[],
"isStarred":false,
"folderId":34,
"folderUid":"<redacted>",
"folderTitle":"Test Folder",
"folderUrl":"/dashboards/dashboards/f/<redacted>/test-folder"
}

The FoundDashboard interface should probably include that information.

@GiedriusS
Copy link
Collaborator

So why not continue with #101 ? :)

@bg451
Copy link
Author

bg451 commented Aug 3, 2020

Just wanted to make sure y'all were okay with the work before creating a PR with no context, I'll go ahead and reopen it!

@safaci2000
Copy link
Contributor

This is fixed I think? Since #101 is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants