Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copilot optimization #1244

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Copilot optimization #1244

merged 1 commit into from
Jan 17, 2025

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Jan 16, 2025

Related:

Copy link

qiniu-prow bot commented Jan 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 17 changed files in this pull request and generated 1 comment.

Files not reviewed (12)
  • spx-backend/internal/copilot/gop_defs.json: Language not supported
  • spx-backend/internal/copilot/spx_defs.json: Language not supported
  • spx-gui/package-lock.json: Language not supported
  • spx-gui/package.json: Language not supported
  • spx-gui/src/components/editor/code-editor/ui/markdown/CodeChange.vue: Evaluated as low risk
  • spx-backend/internal/copilot/prompt.go: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/copilot/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/common.ts: Evaluated as low risk
  • spx-backend/internal/controller/copilot.go: Evaluated as low risk
  • spx-backend/internal/copilot/system_prompt.md: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/document-base/spx/index.ts: Evaluated as low risk
  • spx-backend/internal/copilot/gop_defs.md: Evaluated as low risk
Comments suppressed due to low confidence (1)

spx-gui/src/components/editor/code-editor/document-base/helpers.ts:22

  • Ensure that the CSV conversion handles special characters and line breaks correctly in the descriptions.
const csvStringify = await import('csv-stringify/browser/esm/sync').then((m) => m.stringify)

spx-gui/src/components/editor/code-editor/copilot.ts Outdated Show resolved Hide resolved
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 18 changed files in this pull request and generated 1 comment.

Files not reviewed (13)
  • spx-backend/internal/copilot/gop_defs.json: Language not supported
  • spx-backend/internal/copilot/spx_defs.json: Language not supported
  • spx-gui/package-lock.json: Language not supported
  • spx-gui/package.json: Language not supported
  • spx-gui/src/components/editor/code-editor/ui/markdown/CodeView.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/CodeChange.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/common.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/copilot.ts: Evaluated as low risk
  • spx-backend/internal/copilot/prompt.go: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/copilot/index.ts: Evaluated as low risk
  • spx-backend/internal/controller/copilot.go: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/document-base/spx/index.ts: Evaluated as low risk
  • spx-backend/internal/copilot/gop_defs.md: Evaluated as low risk
Comments suppressed due to low confidence (1)

spx-backend/internal/copilot/custom_element_code_change.md:5

  • Inconsistent use of 'NOTE' and 'NOTE:'. Standardize to one format for better readability.
NOTE:

Messages: anthropic.F(messages),
Temperature: anthropic.F(0.3),
Temperature: anthropic.F(0.1),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证 Copilot 正确地使用 spx API、custom element 等的过程中发现 low temperature 确实很重要 🤣


const maxChatMessageCount = 20
const maxChatMessageCount = 10
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 太多了,测试下来 10 条往上就容易超时了

@nighca nighca marked this pull request as ready for review January 16, 2025 09:53
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit 2681bee into goplus:dev Jan 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copilot context optimization when project code too long Copilot response speed improvement
3 participants