From f64be294d2b40052419c5a35e9de34aee80cc424 Mon Sep 17 00:00:00 2001
From: Brett McLarnon <bmclarnon@google.com>
Date: Fri, 23 Aug 2024 12:19:41 -0700
Subject: [PATCH] Update workflow to support caching & less configuration.

---
 .github/workflows/build.yaml       | 141 ++++++++++-------------------
 BUILD                              |  28 ++++--
 buildconfigs/agg_core.sh           |  16 ----
 buildconfigs/fed_sql.sh            |  16 ----
 buildconfigs/ledger_enclave_app.sh |  16 ----
 buildconfigs/sql_server.sh         |  16 ----
 scripts/build.sh                   |   4 +-
 7 files changed, 72 insertions(+), 165 deletions(-)
 delete mode 100644 buildconfigs/agg_core.sh
 delete mode 100644 buildconfigs/fed_sql.sh
 delete mode 100644 buildconfigs/ledger_enclave_app.sh
 delete mode 100644 buildconfigs/sql_server.sh

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 8136e86..7e7ee2b 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -12,121 +12,76 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  build_attest_all:
-    strategy:
-      fail-fast: false
-      matrix:
-        buildconfig:
-          - buildconfigs/agg_core.sh
-          - buildconfigs/fed_sql.sh
-          - buildconfigs/ledger_enclave_app.sh
-          - buildconfigs/sql_server.sh
+  build:
+    outputs:
+      binaries: ${{ steps.list-binaries.outputs.binaries }}
 
     permissions:
-      actions: read
-      id-token: write
-      attestations: write
       contents: read
 
     runs-on: ubuntu-20.04
 
     steps:
-      # Needed for GCS upload.
-      - name: Authenticate to Google Cloud
-        uses: google-github-actions/auth@v2
+      - uses: actions/checkout@v4
+      - uses: bazel-contrib/setup-bazel@0.8.5
         with:
-          credentials_json: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY_JSON }}
-
-      # Needed for GCS upload.
-      - name: Setup Google Cloud
-        uses: google-github-actions/setup-gcloud@v2
-
-      - name: Mount main branch
-        uses: actions/checkout@v4
-
-      # Keeps two versions of SUBJECT_PATHS, with space resp. comma as
-      # path separator. Both are needed in later steps.
-      - name: Parse buildconfig
-        id: parse
+          bazelisk-cache: true
+          disk-cache: ${{ github.workflow }}
+          repository-cache: true
+      - name: Bazel Build
+        run: bazelisk run //:install_release_binaries -- --destdir="${{ runner.temp }}/binaries"
+      - name: List Binaries
+        id: list-binaries
         run: |
-          set -o errexit
-          set -o nounset
-          set -o pipefail
-          source ${{ matrix.buildconfig }}
-          echo "package-name=${PACKAGE_NAME}" >> "${GITHUB_OUTPUT}"
-          paths="${SUBJECT_PATHS[@]}"
-          echo "subject-paths=${paths}" >> "${GITHUB_OUTPUT}"
-          echo "subject-paths-commas=${paths// /,}" >> "${GITHUB_OUTPUT}"
+          set -euxo pipefail
+          binaries="$(find "${{ runner.temp }}/binaries" -type f -printf '%P\n' | jq -Rsc 'split("\n")[:-1]')"
+          echo "binaries=${binaries}" >> "$GITHUB_OUTPUT"
+      - uses: actions/upload-artifact@v4
+        with:
+          name: binaries
+          path: ${{ runner.temp }}/binaries/
+          if-no-files-found: error
+          retention-days: 5
 
-      - name: Show values
-        run: |
-          set -o errexit
-          set -o nounset
-          set -o pipefail
-          gsutil --version
-          echo "package_name: ${{ steps.parse.outputs.package-name }}"
-          echo "subject_paths: ${{ steps.parse.outputs.subject-paths }}"
-          echo "subject_paths_commas: ${{ steps.parse.outputs.subject-paths-commas }}"
-          echo "GITHUB_SHA: ${GITHUB_SHA}"
+  attest:
+    needs: build
 
-      - name: Build
-        id: build
-        run: |
-          set -o errexit
-          set -o nounset
-          set -o pipefail
-          source ${{ matrix.buildconfig }}
-          eval "${BUILD_COMMAND[@]}"
+    permissions:
+      id-token: write
+      attestations: write
 
-      - name: Show build artifacts
-        run: |
-          echo "${{ steps.parse.outputs.subject-paths }}"
-          ls -la ${{ steps.parse.outputs.subject-paths }}
+    runs-on: ubuntu-20.04
+
+    strategy:
+      fail-fast: false
+      matrix:
+        binary: ${{ fromJson(needs.build.outputs.binaries) }}
 
-      - name: Attest
+    steps:
+      - uses: google-github-actions/auth@v2
+        with:
+          credentials_json: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY_JSON }}
+      - uses: google-github-actions/setup-gcloud@v2
+        with:
+          skip_install: true
+      - uses: actions/download-artifact@v4
+        with:
+          name: binaries
+      - uses: actions/attest-build-provenance@v1
         id: attest
-        uses: actions/attest-build-provenance@v1.1.1
         with:
-          subject-path: ${{ steps.parse.outputs.subject-paths-commas }}
-
-      - name: Show bundle
-        run: |
-          echo "${{ steps.attest.outputs.bundle-path }}"
-          ls -la "${{ steps.attest.outputs.bundle-path }}"
-          cat "${{ steps.attest.outputs.bundle-path }}"
-
-      # Upload binary and provenance to GCS and index via http://static.space
-      # so that, regardless of the GCS bucket and path, it can easily be
-      # located by its digest.
+          subject-path: ${{ matrix.binary }}
       - name: Upload
-        id: upload
         run: |
-          set -o errexit
-          set -o nounset
-          set -o pipefail
-          set -o xtrace
+          set -euxo pipefail
 
           bucket=oak-bins
-          package_name=${{ steps.parse.outputs.package-name }}
-          subject_paths=( ${{ steps.parse.outputs.subject-paths }} )
-          binary_path="${subject_paths[0]}"
-          provenance_path=${{ steps.attest.outputs.bundle-path }}
+          binary_path="${{ matrix.binary }}"
+          package_name="${binary_path%%/*}"
+          provenance_path="${{ steps.attest.outputs.bundle-path }}"
 
           gcs_binary_path="binary/${GITHUB_SHA}/${package_name}/binary"
           gcs_provenance_path="provenance/${GITHUB_SHA}/${package_name}/attestation.jsonl"
-          binary_url="https://storage.googleapis.com/${bucket}/${gcs_binary_path}"
-          provenance_url="https://storage.googleapis.com/${bucket}/${gcs_provenance_path}"
 
           gsutil cp "${binary_path}" "gs://${bucket}/${gcs_binary_path}"
           gsutil cp "${provenance_path}" "gs://${bucket}/${gcs_provenance_path}"
-
-          curl --fail \
-            --request POST \
-            --header 'Content-Type: application/json' \
-            --data "{ \"url\": \"${binary_url}\" }" \
-            https://api.static.space/v1/snapshot
-          curl --fail \
-            --request POST \
-            --header 'Content-Type: application/json' \
-            --data "{ \"url\": \"${provenance_url}\" }" \
-            https://api.static.space/v1/snapshot
diff --git a/BUILD b/BUILD
index 9153974..7917ad1 100644
--- a/BUILD
+++ b/BUILD
@@ -31,18 +31,34 @@ platform(
     parents = ["@local_config_platform//:host"],
 )
 
-# All artifacts that will be built for release, along with their names in the
+# All release (i.e. production) binaries, along with their names in the
 # destination directory.
-_ALL_BINARIES = {
+_RELEASE_BINARIES = {
     "//containers/agg_core:oci_runtime_bundle.tar": "agg_core/container.tar",
-    "//containers/confidential_transform_test_concat:oci_runtime_bundle.tar": "confidential_transform_test_concat/container.tar",
     "//containers/fed_sql:oci_runtime_bundle.tar": "fed_sql/container.tar",
     "//containers/sql_server:oci_runtime_bundle.tar": "sql_server/container.tar",
+    "//ledger_enclave_app": "ledger/binary",
+    "//replicated_ledger_enclave_app": "replicated_ledger/binary",
+}
+
+pkg_files(
+    name = "release_binaries",
+    srcs = _RELEASE_BINARIES.keys(),
+    renames = _RELEASE_BINARIES,
+)
+
+pkg_install(
+    name = "install_release_binaries",
+    srcs = [":release_binaries"],
+)
+
+# All release and testing binaries, along with their names in the destination
+# directory.
+_ALL_BINARIES = _RELEASE_BINARIES | {
+    "//containers/confidential_transform_test_concat:oci_runtime_bundle.tar": "confidential_transform_test_concat/container.tar",
     "//containers/test_concat:oci_runtime_bundle.tar": "test_concat/container.tar",
     "//examples/square_enclave_app": "square_example/binary",
     "//examples/sum_enclave_app": "sum_example/binary",
-    "//ledger_enclave_app": "ledger/binary",
-    "//replicated_ledger_enclave_app": "replicated_ledger/binary",
 }
 
 pkg_files(
@@ -52,6 +68,6 @@ pkg_files(
 )
 
 pkg_install(
-    name = "install_binaries",
+    name = "install_all_binaries",
     srcs = [":all_binaries"],
 )
diff --git a/buildconfigs/agg_core.sh b/buildconfigs/agg_core.sh
deleted file mode 100644
index 7d1bc0f..0000000
--- a/buildconfigs/agg_core.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/bash
-#
-# Build configuration for agg_core.
-#
-export PACKAGE_NAME=agg_core
-
-export BUILD_COMMAND=(
-  scripts/build_target.sh
-  --output_dir
-  binaries
-  //containers/agg_core:oci_runtime_bundle.tar
-)
-
-export SUBJECT_PATHS=(
-  binaries/agg_core/container.tar
-)
diff --git a/buildconfigs/fed_sql.sh b/buildconfigs/fed_sql.sh
deleted file mode 100644
index 6e13a8e..0000000
--- a/buildconfigs/fed_sql.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/bash
-#
-# Build configuration for fed_sql.
-#
-export PACKAGE_NAME=fed_sql
-
-export BUILD_COMMAND=(
-  scripts/build_target.sh
-  --output_dir
-  binaries
-  //containers/fed_sql:oci_runtime_bundle.tar
-)
-
-export SUBJECT_PATHS=(
-  binaries/fed_sql/container.tar
-)
diff --git a/buildconfigs/ledger_enclave_app.sh b/buildconfigs/ledger_enclave_app.sh
deleted file mode 100644
index 6640dce..0000000
--- a/buildconfigs/ledger_enclave_app.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/bash
-#
-# Build configuration for ledger_enclave_app.
-#
-export PACKAGE_NAME=ledger
-
-export BUILD_COMMAND=(
-  scripts/build_target.sh
-  --output_dir
-  binaries
-  //ledger_enclave_app:ledger_enclave_app
-)
-
-export SUBJECT_PATHS=(
-  binaries/ledger/binary
-)
diff --git a/buildconfigs/sql_server.sh b/buildconfigs/sql_server.sh
deleted file mode 100644
index 73c9a27..0000000
--- a/buildconfigs/sql_server.sh
+++ /dev/null
@@ -1,16 +0,0 @@
-#!/bin/bash
-#
-# Build configuration for sql_server.
-#
-export PACKAGE_NAME=sql_server
-
-export BUILD_COMMAND=(
-  scripts/build_target.sh
-  --output_dir
-  binaries
-  //containers/sql_server:oci_runtime_bundle.tar
-)
-
-export SUBJECT_PATHS=(
-  binaries/sql_server/container.tar
-)
diff --git a/scripts/build.sh b/scripts/build.sh
index e8a1853..e96aa40 100755
--- a/scripts/build.sh
+++ b/scripts/build.sh
@@ -46,10 +46,10 @@ elif [ "$1" == "release" ]; then
   # BINARY_OUTPUTS_DIR may be unset if this script is run manually; it'll
   # always be set during CI builds.
   if [[ -n "${BINARY_OUTPUTS_DIR}" ]]; then
-    ${BAZELISK} run -c opt //:install_binaries -- --destdir "${BINARY_OUTPUTS_DIR}"
+    ${BAZELISK} run -c opt //:install_all_binaries -- --destdir "${BINARY_OUTPUTS_DIR}"
   else
     # If unset, verify the binaries can be built with -c opt.
-    ${BAZELISK} build -c opt //:install_binaries
+    ${BAZELISK} build -c opt //:install_all_binaries
   fi
 else
   ${BAZELISK} test //...