Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins add command flags #205

Open
kquerna opened this issue Oct 30, 2020 · 0 comments
Open

Plugins add command flags #205

kquerna opened this issue Oct 30, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@kquerna
Copy link
Contributor

kquerna commented Oct 30, 2020

Description

In order to allow plugins to add flags to commands, we need a new getCommandFlags lifecycle.
Plugins can use this command to add custom flags that they want to listen for. By default
new flags will be added for all commands. The getCommandFlags lifecycle should allow plugins to also limit
which commands should be effected.

As a first custom, we should update @gasket/plugin-metrics to use the new lifecycle to add the record flag
and drop it (from the command plugin).

Package(s): @gasket/plugin-command

AC:

  • Ability for plugins to add custom flags to commands
  • Ability to limit which commands receive flags
  • Update @gasket/plugin-metrics to add record flag
@kquerna kquerna added the enhancement New feature or request label Oct 30, 2020
@kquerna kquerna added this to the v6.x milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant