Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream ostree go bindings #333

Open
evelikov opened this issue Apr 29, 2022 · 4 comments
Open

Switch to upstream ostree go bindings #333

evelikov opened this issue Apr 29, 2022 · 4 comments

Comments

@evelikov
Copy link

While hacking on a CI lint stage for debos, I noticed that we're using a fork of https://github.com/ostreedev/ostree-go namely - github.com/sjoerdsimons/ostree-go

Seemingly there are two upstream MRs needed in order to converge:

Create this a task here so there is some clarity and cross-references. @sjoerdsimons @eds-collabora
feel free to provide background information and details as you see fit.

@obbardc
Copy link
Member

obbardc commented Apr 29, 2022

I think there are more upstream PRs needed to be created than the two you have linked.

Some baby-steps going forward:

  1. move the fork to the go-debos namespace & switch debos to use the go-debos fork
  2. rebase the fork ontop of https://github.com/ostreedev/ostree-go & drop merged commits
  3. find out what remains to be pushed upstream, split into branches and create PRs upstream
  4. switch debos to upstream repository and remove go-debos fork

How does that sound for a plan of attack?

@eds-collabora
Copy link

I believe that PR 34 is a subset of a more recent version of PR 10. I got one trivial PR merged when I tried, but got absolutely no traction for this. No questions, nothing. I had more PRs planned/branched that then built on this to bring the codebases into alignment, but I couldn't get off the starting blocks.

@sjoerdsimons
Copy link
Member

ostree-go isn't very active generally and there are a bunch of issues around the go garbage collector and ostree works.. I've been wondering if it doesn't make more sense to do a small C/Rust wrapper for libostree directly in go-debos that provides a minimal/trivial API to just address the few operations go-debos needs, rather then fighting the golang binding

@evelikov
Copy link
Author

evelikov commented May 5, 2022

While I do agree that upstream being slow/inactive is a hurdle, it seems that adding a new wrapper will add more technical debt/burden to go-debos. I'm a little concerted that using different language may raise the bar for contributions and/or adoption.

That said, the decision is above my noobie contributor status to the project, so take my input with pinch of salt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants