Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we're supporting find_by! #2

Open
glacials opened this issue Nov 1, 2020 · 0 comments
Open

Ensure we're supporting find_by! #2

glacials opened this issue Nov 1, 2020 · 0 comments

Comments

@glacials
Copy link
Owner

glacials commented Nov 1, 2020

In manual testing it appears we work with find_by!, but its source implies we shouldn't be working with it, as it doesn't depend on find_by. We should make sure we are supporting it, and do so in a way that doesn't accidentally cause us to call expand twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glacials