From 1d4866b058d22bfd3886703c302daa1d9db6dba1 Mon Sep 17 00:00:00 2001 From: Henry Mercer Date: Fri, 2 Feb 2024 19:16:01 +0000 Subject: [PATCH 1/2] Only run custom `checkout_path` tests against a single CodeQL version These tests do not depend on the CodeQL version. --- .github/workflows/__with-checkout-path.yml | 36 ---------------------- pr-checks/checks/with-checkout-path.yml | 1 + 2 files changed, 1 insertion(+), 36 deletions(-) diff --git a/.github/workflows/__with-checkout-path.yml b/.github/workflows/__with-checkout-path.yml index 9443a176d9..9b5a97232b 100644 --- a/.github/workflows/__with-checkout-path.yml +++ b/.github/workflows/__with-checkout-path.yml @@ -25,48 +25,12 @@ jobs: strategy: matrix: include: - - os: ubuntu-latest - version: stable-20221211 - - os: macos-latest - version: stable-20221211 - - os: windows-latest - version: stable-20221211 - - os: ubuntu-latest - version: stable-20230418 - - os: macos-latest - version: stable-20230418 - - os: windows-latest - version: stable-20230418 - - os: ubuntu-latest - version: stable-v2.13.5 - - os: macos-latest - version: stable-v2.13.5 - - os: windows-latest - version: stable-v2.13.5 - - os: ubuntu-latest - version: stable-v2.14.6 - - os: macos-latest - version: stable-v2.14.6 - - os: windows-latest - version: stable-v2.14.6 - - os: ubuntu-latest - version: default - - os: macos-latest - version: default - - os: windows-latest - version: default - os: ubuntu-latest version: latest - os: macos-latest version: latest - os: windows-latest version: latest - - os: ubuntu-latest - version: nightly-latest - - os: macos-latest - version: nightly-latest - - os: windows-latest - version: nightly-latest name: Use a custom `checkout_path` permissions: contents: read diff --git a/pr-checks/checks/with-checkout-path.yml b/pr-checks/checks/with-checkout-path.yml index ccc8fa1a3b..5afaa51424 100644 --- a/pr-checks/checks/with-checkout-path.yml +++ b/pr-checks/checks/with-checkout-path.yml @@ -1,5 +1,6 @@ name: "Use a custom `checkout_path`" description: "Checks that a custom `checkout_path` will find the proper commit_oid" +versions: ["latest"] steps: # This ensures we don't accidentally use the original checkout for any part of the test. - name: Delete original checkout From e1fa6ddb4afa78b6a273e0102040b003e54e96db Mon Sep 17 00:00:00 2001 From: Henry Mercer Date: Fri, 2 Feb 2024 19:16:47 +0000 Subject: [PATCH 2/2] Disable debug mode in checkout path tests This avoids uploading debug artifacts, which takes a while. --- .github/workflows/__with-checkout-path.yml | 1 - pr-checks/checks/with-checkout-path.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/__with-checkout-path.yml b/.github/workflows/__with-checkout-path.yml index 9b5a97232b..22f3960e2e 100644 --- a/.github/workflows/__with-checkout-path.yml +++ b/.github/workflows/__with-checkout-path.yml @@ -84,7 +84,6 @@ jobs: # it's enough to test one compiled language and one interpreted language languages: csharp,javascript source-root: x/y/z/some-path/tests/multi-language-repo - debug: true - name: Build code shell: bash diff --git a/pr-checks/checks/with-checkout-path.yml b/pr-checks/checks/with-checkout-path.yml index 5afaa51424..481a624c29 100644 --- a/pr-checks/checks/with-checkout-path.yml +++ b/pr-checks/checks/with-checkout-path.yml @@ -23,7 +23,6 @@ steps: # it's enough to test one compiled language and one interpreted language languages: csharp,javascript source-root: x/y/z/some-path/tests/multi-language-repo - debug: true - name: Build code shell: bash