Allow users to pass in a custom linting configuration #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 116 out of 117 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
more information
khiga8
reviewed
Jan 10, 2025
JoyceZhu
reviewed
Jan 24, 2025
JoyceZhu
reviewed
Jan 24, 2025
JoyceZhu
reviewed
Jan 24, 2025
JoyceZhu
reviewed
Jan 24, 2025
README.md
Outdated
|
|
||
| ```yml | ||
| steps: | ||
| - name: Check alt text #change this step to use the |
There was a problem hiding this comment.
#change this step to use the
I think this got cut off?
JoyceZhu
reviewed
Jan 24, 2025
| export const validate = (markdown) => | ||
| (markdownlint | ||
| export const validate = (markdown, config) => { | ||
| const configObject = yaml.load(config) |
There was a problem hiding this comment.
does this function handle if the extra custom config doesn't exist?
There was a problem hiding this comment.
Sure does! I have a test repo that I will invite you too.
kendallgassner
commented
Jan 24, 2025
Co-authored-by: Joyce Zhu <[email protected]>
JoyceZhu
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #34
What
This PR adds the ability to pass a custom linting configuration object to the github/accessibility-alt-text-bot action. The configuration will allow users to include more linting rules from the markdownlint or markdownlint-github rulesets.