Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the footer for landscape Mode!! #104

Open
DARK-art108 opened this issue Oct 12, 2020 · 16 comments
Open

Fix the footer for landscape Mode!! #104

DARK-art108 opened this issue Oct 12, 2020 · 16 comments
Assignees
Labels
Designs Designing Task enhancement New feature or request good first issue Good for newcomers Hacktoberfest 2020 Hacktoberfest 2020

Comments

@DARK-art108
Copy link
Collaborator

Screenshot_20201012-123546__01

@DARK-art108 DARK-art108 added duplicate This issue or pull request already exists good first issue Good for newcomers Hacktoberfest 2020 Hacktoberfest 2020 Designs Designing Task enhancement New feature or request and removed duplicate This issue or pull request already exists labels Oct 12, 2020
@mahimagoyalx
Copy link
Contributor

mahimagoyalx commented Oct 12, 2020

I would like to take this issue, please elaborate on what needs to be fixed except for merging the support column into one. @DARK-art108

@ishi0301
Copy link
Contributor

I would like to help @mahimagoyalx in this

@sjchoure
Copy link
Contributor

@mahimagoyalx, As you can see the footer is shifted to the left and not at the center.
Can you make the footer centered with respect to the page like shown below?
footersample

@sjchoure
Copy link
Contributor

@ishi0301 , It is not that big a task and can be handled by an individual as well. You can take other issues that are currently open.

@mahimagoyalx
Copy link
Contributor

@saviourcode @DARK-art108 I got it, please assign me this issue.

@sjchoure
Copy link
Contributor

@mahimagoyalx All the best!

@mahimagoyalx
Copy link
Contributor

For less than 1200px width
lessthan1200

For more than 1200px width
morethan1200

Should I make the pull request? @saviourcode @DARK-art108

@sjchoure
Copy link
Contributor

@mahimagoyalx is it possible to create just a one singe row of the all the column with some space between them?
Like there is still some space in between the left side of the footer and logo

@sjchoure
Copy link
Contributor

footersample

Reference this picture for final result

@mahimagoyalx
Copy link
Contributor

mahimagoyalx commented Oct 13, 2020

Then for less than 1200px width all the columns will compress, come really close to each other and won't look good. @saviourcode

@sjchoure
Copy link
Contributor

Yeah, that's why we need to increase the spacing between them. If you want you might consider reducing logo size for more space.

@sjchoure
Copy link
Contributor

@mahimagoyalx Is the issue complete :)

@mahimagoyalx
Copy link
Contributor

@mahimagoyalx Is the issue complete :)

making the pull request in 15.

@himanshubobade
Copy link

hey i would like to work on it

@sjchoure
Copy link
Contributor

sjchoure commented Oct 20, 2020

@himanshubobade sorry but this issue is fixed. You may check other open issues #108 and #109

@himanshubobade
Copy link

@saviourcode okay i will work on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Designs Designing Task enhancement New feature or request good first issue Good for newcomers Hacktoberfest 2020 Hacktoberfest 2020
Projects
None yet
Development

No branches or pull requests

5 participants