-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add range minimum query kernels #1764
Open
upsj
wants to merge
29
commits into
develop
Choose a base branch
from
rmq
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constexpr evaluation complexity too high
…ssing) see TODOs for problematic points
ginkgo-bot
added
reg:build
This is related to the build system.
reg:testing
This is related to testing.
mod:core
This is related to the core module.
mod:cuda
This is related to the CUDA module.
labels
Jan 11, 2025
ginkgo-bot
added
mod:reference
This is related to the reference module.
mod:hip
This is related to the HIP module.
labels
Jan 11, 2025
my first impression on turning |
L includes fill-in, A does not |
* the larger lookup table overflows the default 1MB stack size * the intrinsics are different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:ready-for-review
This PR is ready for review
mod:core
This is related to the core module.
mod:cuda
This is related to the CUDA module.
mod:hip
This is related to the HIP module.
mod:reference
This is related to the reference module.
reg:build
This is related to the build system.
reg:testing
This is related to testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a data structure to answer queries of the kind$\text{argmin}_{i \in [a,b]} \text{array}[i]$ in constant time. This will be used to speed up the computation of LCAs in the symbolic Cholesky algorithm, turning the counting step from $O(nnz(L))$ algorithm to a $O(nnz(A))$ algorithm.
The corresponding Wikipedia articles describe the algorithms pretty well https://en.wikipedia.org/wiki/Range_minimum_query, the constant time query is described in more detail in J. Fischer and V. Heun, “Space-Efficient Preprocessing Schemes for Range Minimum Queries on Static Arrays,” SIAM J. Comput., vol. 40, no. 2, pp. 465–492, Jan. 2011, doi: 10.1137/090779759.
TODO: