-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dist] remove distributed version of EnableLinOp #1751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM!
b092407
to
3205c10
Compare
Co-authored-by: Yu-Hsiang M. Tsai <[email protected]>
3205c10
to
df937da
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1751 +/- ##
===========================================
- Coverage 89.52% 89.51% -0.01%
===========================================
Files 797 794 -3
Lines 65889 65800 -89
===========================================
- Hits 58989 58904 -85
+ Misses 6900 6896 -4 ☔ View full report in Codecov by Sentry. |
This PR removes the
EnableDistributedLinOp
mixin class. Instead, the distributed linops can now directly derive fromEnableLinOp
. To make this work, theEnablePolymorphicObject
now checks if theConcreteType
is derived fromDistributedBase
, and uses the(exec, comm)
constructor in that case. (This is now possible due to theif constexpr
in c++17.)