Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dist] remove distributed version of EnableLinOp #1751

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

MarcelKoch
Copy link
Member

This PR removes the EnableDistributedLinOp mixin class. Instead, the distributed linops can now directly derive from EnableLinOp. To make this work, the EnablePolymorphicObject now checks if the ConcreteType is derived from DistributedBase, and uses the (exec, comm) constructor in that case. (This is now possible due to the if constexpr in c++17.)

@MarcelKoch MarcelKoch added the 1:ST:ready-for-review This PR is ready for review label Dec 11, 2024
@MarcelKoch MarcelKoch self-assigned this Dec 11, 2024
@ginkgo-bot ginkgo-bot added the mod:core This is related to the core module. label Dec 11, 2024
include/ginkgo/core/base/polymorphic_object.hpp Outdated Show resolved Hide resolved
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@MarcelKoch MarcelKoch added the 1:ST:ready-to-merge This PR is ready to merge. label Dec 11, 2024
@MarcelKoch MarcelKoch force-pushed the remove-enabledistributedlinop branch from b092407 to 3205c10 Compare December 11, 2024 16:22
@MarcelKoch MarcelKoch removed the 1:ST:ready-for-review This PR is ready for review label Dec 11, 2024
@MarcelKoch MarcelKoch force-pushed the remove-enabledistributedlinop branch from 3205c10 to df937da Compare December 12, 2024 08:27
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (f296349) to head (df937da).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
include/ginkgo/core/base/polymorphic_object.hpp 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1751      +/-   ##
===========================================
- Coverage    89.52%   89.51%   -0.01%     
===========================================
  Files          797      794       -3     
  Lines        65889    65800      -89     
===========================================
- Hits         58989    58904      -85     
+ Misses        6900     6896       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcelKoch MarcelKoch merged commit abe9ecf into develop Dec 13, 2024
13 of 14 checks passed
@MarcelKoch MarcelKoch deleted the remove-enabledistributedlinop branch December 13, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants