fix format_header usage #1477
Merged
fix format_header usage #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
upsj
approved these changes
Nov 28, 2023
MarcelKoch
approved these changes
Nov 28, 2023
yhmtsai
added
1:ST:ready-to-merge
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the format_header usage in pre-commit.
Sorry for another pr.
I only tested one file so I did not have the issue before.
format_header uses some file to cache content, so it can not run in parallel.
The main ginkgo header does not fit the regroup.
format_header changes it (failed) -> update ginkgo header changes it back (failed)
no file is changed in the end though