Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyboardInterrupt() error visible in terminal when exiting eopkg history with sigint (CTRL+C) #105

Open
2 tasks done
pjolt opened this issue Nov 16, 2024 · 5 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@pjolt
Copy link

pjolt commented Nov 16, 2024

Please confirm there isn't an open report for this issue

  • I have searched through bug reports

Summary

Entering eopkg history and exiting via CTRL+C results in KeyboardInterrupt() errors on both XFCE and Budgie

Steps to reproduce

  1. sudo eopkg history
  2. Enter sudo password to view history
  3. Exit with CTRL+C

Expected result

No error visible in terminal.
Screenshot from Plasma after performing the same steps

Screenshot_20241116_091854

Actual result

KeyboardInterrupt: KeyboardInterrupt() in <bound method LessPipe.__del__ of <pisi.cli.history.LessPipe instance at 0x7f1ab4284460>> ignored

Screenshot_20241116_075839

Environment

  • Is system up to date?

Repo

Shannon (stable)

Desktop Environment

Other

System details

INXI -B

XFCe

System:
  Host: test-solus Kernel: 6.11.7-309.current arch: x86_64 bits: 64
  Desktop: Xfce v: 4.18.1 Distro: Solus 4.6 convergence
Machine:
  Type: Kvm System: QEMU product: Standard PC (i440FX + PIIX, 1996)
    v: pc-i440fx-7.2 serial: <superuser required>
  Mobo: N/A model: N/A serial: N/A BIOS: SeaBIOS
    v: rel-1.16.1-0-g3208b098f51a-prebuilt.qemu.org date: 04/01/2014
CPU:
  Info: quad core 13th Gen Intel Core i7-13700KF [MCP] speed (MHz): avg: 3418
Graphics:
  Device-1: Red Hat QXL paravirtual graphic card driver: qxl v: kernel
  Display: x11 server: X.Org v: 21.1.14 with: Xwayland v: 24.1.4 driver:
    gpu: qxl resolution: 1024x768~60Hz
  API: OpenGL v: 4.5 vendor: mesa v: 24.2.7 renderer: llvmpipe (LLVM 18.1.8
    256 bits)
Network:
  Device-1: Intel 82371AB/EB/MB PIIX4 ACPI type: network bridge
    driver: piix4_smbus
  Device-2: Realtek RTL-8100/8101L/8139 PCI Fast Ethernet Adapter
    driver: 8139cp
Drives:
  Local Storage: total: 22 GiB used: 8.88 GiB (40.4%)
Info:
  Memory: total: 4 GiB available: 3.82 GiB used: 1.35 GiB (35.4%)
  Processes: 188 Uptime: 41m Shell: Bash inxi: 3.3.36

Budgie

System:
  Host: test-solus Kernel: 6.11.7-309.current arch: x86_64 bits: 64
  Desktop: Budgie v: 10.9.2 Distro: Solus 4.6 convergence
Machine:
  Type: Kvm System: QEMU product: Standard PC (i440FX + PIIX, 1996)
    v: pc-i440fx-7.2 serial: <superuser required>
  Mobo: N/A model: N/A serial: N/A BIOS: SeaBIOS
    v: rel-1.16.1-0-g3208b098f51a-prebuilt.qemu.org date: 04/01/2014
CPU:
  Info: quad core 13th Gen Intel Core i7-13700KF [MCP] speed (MHz): avg: 3418
Graphics:
  Device-1: Red Hat QXL paravirtual graphic card driver: qxl v: kernel
  Display: x11 server: X.Org v: 21.1.14 with: Xwayland v: 24.1.4 driver:
    gpu: qxl resolution: 2560x1358~60Hz
  API: OpenGL v: 4.5 vendor: mesa v: 24.2.7 renderer: llvmpipe (LLVM 18.1.8
    256 bits)
Network:
  Device-1: Intel 82371AB/EB/MB PIIX4 ACPI type: network bridge
    driver: piix4_smbus
  Device-2: Realtek RTL-8100/8101L/8139 PCI Fast Ethernet Adapter
    driver: 8139cp
Drives:
  Local Storage: total: 22 GiB used: 9.94 GiB (45.2%)
Info:
  Memory: total: 4 GiB available: 3.82 GiB used: 1.09 GiB (28.6%)
  
Processes: 219 Uptime: 1m Shell: Bash inxi: 3.3.36

Other comments

Installed and updated both VMs ~14 hours ago and no changes whatsoever to defaults besides installing Gnome-Software through terminal and shut down both.
Now doing the latest w46 upgrade on both through Gnome-Software without visible errors, rebooted and immediately went into terminal to check eopkg history which is when i discovered this.

  • Both VMs have been rebooted a couple of additional times and error output remains
  • VMs running on Gnome Boxes Flatpak
  • ISOs used to install is the latest 2024-10-14 on both
@pjolt pjolt added the bug Something isn't working label Nov 16, 2024
@pjolt
Copy link
Author

pjolt commented Nov 16, 2024

After further testing by installing fresh VMs again in Gnome Boxes using the 2024-10-14 ISOs i get KeyboardInterrupt() error on Budgie, XFCE and KDE Plasma
(I have not tried Gnome)

  • Installing, rebooting and issuing sudo eopkg history then exiting out with CTRL+C displays the KeyboardInterrupt() error.
    To be clear no upgrade or additional pkgs installed at this point.

  • Performing eopkg upgrade and a reboot and the error output in terminal remains

  • Performing the steps to repair packages does not solve it and error output remains

Above mentioned Expected result without any visible KeyboardInterrupt() error is what i have on two baremetal installs done from KDE Plasma 4.5 ISO and both have been upgraded continuously.

To be clear this might be a non-issue and more related to my specific setup for some reason but thought i'd report my findings just in case. And if there is anything else you want me to try let me know how and what and i'll try to help best i can.

@pjolt pjolt changed the title KeyboardInterrupt() error in terminal on SIGINT (CTRL+C) viewing eopkg history on Budgie & XFCE KeyboardInterrupt() error visible in terminal when exiting eopkg history with sigint (CTRL+C) Nov 16, 2024
@malfisya
Copy link
Member

I think this is always the expected behavior. To quit eopkg history screen the correct way is to press "Q".

@pjolt
Copy link
Author

pjolt commented Nov 23, 2024

I think this is always the expected behavior. To quit eopkg history screen the correct way is to press "Q".

Displaying Keyboard Interrupt: Exiting... as can be seen in the previously attached screenshot under expected behaviour. seems like a intended (expected) error message.

While KeyboardInterrupt: KeyboardInterrupt() in <bound method LessPipe.__del__ of <pisi.cli.history.LessPipe instance at 0x7f1ab4284460>> ignored seems a bit too.. verbose/confusing and i was not sure if this is done by design or a bug.

But if this is intended you can close this. Thanks!

@TraceyC77
Copy link

TraceyC77 commented Dec 31, 2024

Confirmed the error. While this may be intended (and I have doubts), it's not elegant handling.

Please report this on the eopkg tracker
https://github.com/getsolus/eopkg/issues?

@malfisya malfisya transferred this issue from getsolus/packages Dec 31, 2024
@TraceyC77
Copy link

From a design and UX perspective, the error in the screenshot is the more elegant way to handle this
"Keyboard interrupt: Exiting"

So, while the current behavior in budgie and xfce may be the way things are currently designed, it's still valid to call this a bug since untrapped / unhandled errors are a bug as well as an undesirable UX

The SIGINT should be trapped and a human friendly message output, like that.
This is especially true since it isn't obvious how to exit the command. For contrast, if you go to the man page of anything, at the bottom of the terminal you see "press h for help or q to quit"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

3 participants