Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute boolean value checks #11

Open
subhaze opened this issue Jan 20, 2015 · 4 comments
Open

Attribute boolean value checks #11

subhaze opened this issue Jan 20, 2015 · 4 comments
Assignees
Labels

Comments

@subhaze
Copy link

subhaze commented Jan 20, 2015

allowfullscreen is now supported, however there are no checks in place for the validity of this attribute. From the spec it should only be:

// true
allowfullscreen
allowfullscreen=""
allowfullscreen=allowfullscreen

//false
nothing at all

Figured I would go ahead a file this issue from discussions on #6 and let you decide on whether it should be marked as bug or feature ;)

For references:
http://www.w3.org/html/wg/drafts/html/master/single-page.html#attr-iframe-allowfullscreen
http://www.w3.org/html/wg/drafts/html/master/single-page.html#boolean-attribute

@geoffmcl
Copy link
Owner

Good idea... will think about it...

@geoffmcl geoffmcl self-assigned this Jan 20, 2015
@subhaze
Copy link
Author

subhaze commented Jan 20, 2015

@geoffmcl after filing this, I think, if you do take on this challenge :), it would make more sense if it were a ticket for all attributes that have this restriction instead of just picking allowfullscreen due to it being a current topic. Or tickets for each one associated to some far off milestone?

@geoffmcl
Copy link
Owner

I took it as a ticket for ALL boolean attributes, if that is what you mean, but at present tidy does very little 'attribute' value checking... so will take some time to add... so for now flagged it as a 'feature'...

The fix for #6 was just to not flag it as proprietory, so is sort of unrelated...

@subhaze subhaze changed the title allowfullscreen value checks Attribute boolean value checks Jan 21, 2015
@subhaze
Copy link
Author

subhaze commented Jan 21, 2015

I'd never used Tidy for attribute checking so wasn't sure if there were more instances like this, thanks for the details on that.

I've also updated the ticket title to reflect a more accurate directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants