Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to improve write FITS functionality #19

Merged
merged 35 commits into from
May 31, 2023
Merged

PR to improve write FITS functionality #19

merged 35 commits into from
May 31, 2023

Conversation

drtobybrown
Copy link
Contributor

This PR:

  • do not apply the median subtraction on the output products
  • Include all stellar kinematic product output from PPXF in the FITS products
  • Fix WCS issue with FITS files
  • Fix issue with CDELTi headers not being read
  • Fix issue with incorrect header in tutorial NGC0000.fits
  • Consistent _maps.fits naming convention
  • Various small bug fixes and tidy ups

Toby Brown added 23 commits April 16, 2023 23:34
fix bug where saved FITS is flipped wrt input image
20f31a6
fix bug where saved FITS is flipped wrt input image
6db7248
fix bug where saved FITS is flipped wrt input image
d790f6c
allow for mask in first HDU
6f8fa75
relax python version requirement to >=3.6
89aa843
save emission line FITS maps from GAS module
7f28e90
allow for data in first HDU
6cf8558
apply black and isort formatters
23852e7
fix bug where bins outside galaxy are shown
de09dd7
move save_maps_fits function to new writeFITS module
9c78f4e
add: _writeFITS.py
50592b2
tidy: docstrings and args
c5417fa
apply black
cc8d3a9
add .gitignore
450a11d
update gitignore
6ba145d
Merge branch 'dev-emline-fits'
448cb2b 
Saves emission line and stellar kinematics fits files
add support for CDELTi
57b7ffd
use fits.getheader to read cube hdr
8e5e3e7
remove median subtraction from products
90dc8fc
update printed status to reflect changes
d821eac
tidy up
957e2b4
write all available KIN outputs of ppxf to FITS file, including errors.
b42ad61
fix and sanitize header
38bea5f
This was linked to issues May 29, 2023
Emission line maps output plots #9
Closed
change python requirements in setup.py #11
Open
_lineStrengths.py fails #14
Closed
@drtobybrown
Copy link
Contributor Author

The large amount of changes is because I have applied black and isort code formatters to the entire repo (my IDE is setup to apply on save anyway). IMO code formatters are essential and the black/isort is one of the most popular.

@drtobybrown drtobybrown removed a link to an issue May 29, 2023
_lineStrengths.py fails #14
Closed
@jessevdsande jessevdsande merged commit b672353 into geckos-survey:dev-writefits May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessevdsande jessevdsande Awaiting requested review from jessevdsande

@ameliafm612 ameliafm612 Awaiting requested review from ameliafm612

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change python requirements in setup.py Emission line maps output plots
2 participants
@drtobybrown @jessevdsande