Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a way to make create's super glue unbreakable #470

Open
Discord-Github-Bridge opened this issue Jan 5, 2024 · 13 comments
Open

find a way to make create's super glue unbreakable #470

Discord-Github-Bridge opened this issue Jan 5, 2024 · 13 comments

Comments

@Discord-Github-Bridge
Copy link
Collaborator

autistic.sack.of.friends on Discord says

the basic approaches of just giving it the "unbreakable" tag and setting it's durability to a really big negative number didn't work very well, requiring a normal super glue somewhere in the inventory to drain glue from.

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

What about right click intercept that sets durability to max?

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

That should work

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

yeah, that should work

@Discord-Github-Bridge
Copy link
Collaborator Author

engineersmith_4628 on Discord says

Wouldn't something like

ItemEvents.modification((event) => {
  event.modify("creatre glue"), (item) => {
    item.maxDamage = 0
  })
})
``` Doesn't that make it so it can't die?

@Discord-Github-Bridge
Copy link
Collaborator Author

engineersmith_4628 on Discord says

rather than having another event listening for input

@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

Can someone test that maybe? Would be cool if it's just that

@Discord-Github-Bridge
Copy link
Collaborator Author

engineersmith_4628 on Discord says

I think it should be -1 actually

@EngineerSmith EngineerSmith self-assigned this Jan 27, 2024
@Discord-Github-Bridge
Copy link
Collaborator Author

engineersmith_4628 on Discord says

Tsk of cause it isn't so simple. It doesn't use right click events or anything like that. Glue is checked each tick. I found the code which collects the durability
https://github.com/Creators-of-Create/Create/blob/mc1.18/dev/src/main/java/com/simibubi/create/content/contraptions/glue/SuperGlueSelectionHelper.java#L65

Called @ https://github.com/Creators-of-Create/Create/blob/mc1.19/dev/src/main/java/com/simibubi/create/content/contraptions/glue/SuperGlueSelectionHandler.java#L135

It's possible to override the function with ptdplus - but that isn't a quick fix

@EngineerSmith EngineerSmith removed their assignment Jan 31, 2024
@Discord-Github-Bridge
Copy link
Collaborator Author

yarden.zamir on Discord says

but a right click event does fire no? we can set durability to full on right click

@Discord-Github-Bridge
Copy link
Collaborator Author

engineersmith_4628 on Discord says

The event is consumed - so it isn't fired

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

what's the "instabuild" ability

@Discord-Github-Bridge
Copy link
Collaborator Author

autistic.sack.of.friends on Discord says

is that just when pasting a blueprint

@Discord-Github-Bridge
Copy link
Collaborator Author

engineersmith_4628 on Discord says

I tried that - it's it basically testing creative mode - by enabling it, it causes issues like duplicating tracks when you try to place them as it is used in other parts of create's code base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants