Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpq is not conditional #27

Open
natefoo opened this issue Jan 14, 2025 · 0 comments · May be fixed by #29
Open

libpq is not conditional #27

natefoo opened this issue Jan 14, 2025 · 0 comments · May be fixed by #29
Assignees
@dannon

Comments

@natefoo
Copy link
Member

natefoo commented Jan 14, 2025

I don't know if there is a way to do conditional deps in npm but the introduction of libpq as a dependency means that you have to have the libpq C library (and probably dev package) on your system just to install gx-it-proxy, even if you're not going to be using the postgres support:

npm ERR! code 1
npm ERR! path /home/g2test/node_modules/libpq
npm ERR! command failed
npm ERR! command sh -c -- node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | linux | x64
npm ERR! gyp info find Python using Python version 3.11.4 found at "/cvmfs/test.galaxyproject.org/venv/bin/python3"
npm ERR! gyp info spawn /cvmfs/test.galaxyproject.org/venv/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/home/g2test/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/g2test/node_modules/libpq/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/g2test/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/home/g2test/.cache/node-gyp/18.12.1/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/home/g2test/.cache/node-gyp/18.12.1',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/home/g2test/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/home/g2test/.cache/node-gyp/18.12.1/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/home/g2test/node_modules/libpq',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! /usr/bin/which: no pg_config in (/home/g2test/node_modules/libpq/node_modules/.bin:/home/g2test/node_modules/node_modules/.bin:/home/g2test/node_modules/.bin:/home/node_modules/.bin:/node_modules/.bin:/cvmfs/test.galaxyproject.org/venv/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin:/cvmfs/test.galaxyproject.org/venv/lib/node_modules/.bin:/cvmfs/test.galaxyproject.org/venv/bin:/cvmfs/test.galaxyproject.org/venv/bin:/home/g2test/.local/bin:/home/g2test/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin)
npm ERR! gyp: Call to 'which pg_config || find /usr/bin /usr/local/bin /usr/pg* /opt -executable -name pg_config -print -quit' returned exit status 0 while in binding.gyp. while trying to load binding.gyp
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/home/g2test/node_modules/node-gyp/lib/configure.js:259:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:291:12)
npm ERR! gyp ERR! System Linux 5.14.0-503.14.1.el9_5.x86_64
npm ERR! gyp ERR! command "/cvmfs/test.galaxyproject.org/venv/bin/node" "/home/g2test/node_modules/.bin/node-gyp" "rebuild"
npm ERR! gyp ERR! cwd /home/g2test/node_modules/libpq
npm ERR! gyp ERR! node -v v18.12.1
npm ERR! gyp ERR! node-gyp -v v8.4.1
npm ERR! gyp ERR! not ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannon dannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make pg-native an optional dependency and handle its absence gracefully galaxyproject/gx-it-proxy
2 participants
@dannon @natefoo