From d3c763821ba81f1eeb86fcc8d8705b9fe7eb4445 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Fri, 26 Apr 2024 09:17:37 -0400 Subject: [PATCH 1/3] Fix CitationsList default prop. --- client/src/components/Citation/CitationsList.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/components/Citation/CitationsList.vue b/client/src/components/Citation/CitationsList.vue index 8668cb84e64e..bb6987d8aaec 100644 --- a/client/src/components/Citation/CitationsList.vue +++ b/client/src/components/Citation/CitationsList.vue @@ -18,7 +18,7 @@ const outputFormats = Object.freeze({ interface Props { id: string; source: string; - simple: boolean; + simple?: boolean; } const props = withDefaults(defineProps(), { From fe8ecb12bfb98a7460b00eff54aa90e0be8d3b51 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Fri, 26 Apr 2024 09:30:02 -0400 Subject: [PATCH 2/3] Fix usage of citations_export_message when config is not loaded yet --- client/src/components/Citation/CitationsList.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/components/Citation/CitationsList.vue b/client/src/components/Citation/CitationsList.vue index bb6987d8aaec..00b32419db75 100644 --- a/client/src/components/Citation/CitationsList.vue +++ b/client/src/components/Citation/CitationsList.vue @@ -65,7 +65,7 @@ onMounted(async () => {
-
+
From 97efceafce4c223aaf81ee33ab05023ad9632f7a Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Fri, 26 Apr 2024 11:25:55 -0400 Subject: [PATCH 3/3] Explicitly specify that outputFormat is a string -- this fixes tsc getting confused below when reassigning --- client/src/components/Citation/CitationsList.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/components/Citation/CitationsList.vue b/client/src/components/Citation/CitationsList.vue index 00b32419db75..7aa5b137ff97 100644 --- a/client/src/components/Citation/CitationsList.vue +++ b/client/src/components/Citation/CitationsList.vue @@ -29,7 +29,7 @@ const { config } = useConfig(true); const emit = defineEmits(["rendered", "show", "shown", "hide", "hidden"]); -const outputFormat = ref(outputFormats.CITATION); +const outputFormat = ref(outputFormats.CITATION); const citations = ref([]); onUpdated(() => {