From 1bdacdb74707e8cd7f43b0b735a838bb5291ec08 Mon Sep 17 00:00:00 2001
From: davelopez <46503462+davelopez@users.noreply.github.com>
Date: Wed, 15 Jan 2025 16:10:18 +0100
Subject: [PATCH] Add functionality to delete credential groups in UI

---
 .../src/components/Tool/ToolCredentials.vue   | 14 ++++++
 .../Credentials/ManageToolCredentials.vue     | 10 +++++
 .../User/Credentials/ServiceCredentials.vue   | 43 +++++++++++++++++--
 client/src/stores/userCredentials.ts          | 38 ++++++++++++++++
 4 files changed, 102 insertions(+), 3 deletions(-)

diff --git a/client/src/components/Tool/ToolCredentials.vue b/client/src/components/Tool/ToolCredentials.vue
index b19cb56ed689..68e425894693 100644
--- a/client/src/components/Tool/ToolCredentials.vue
+++ b/client/src/components/Tool/ToolCredentials.vue
@@ -143,6 +143,19 @@ async function onSavedCredentials(providedCredentials: CreateSourceCredentialsPa
     }
 }
 
+async function onDeleteCredentialsGroup(reference: string, groupName: string) {
+    busyMessage.value = "Updating your credentials...";
+    isBusy.value = true;
+    try {
+        userCredentialsStore.deleteCredentialsGroupForTool(props.toolId, reference, groupName);
+    } catch (error) {
+        // TODO: Implement error handling.
+        console.error("Error deleting user credentials group", error);
+    } finally {
+        isBusy.value = false;
+    }
+}
+
 checkUserCredentials();
 </script>
 
@@ -197,6 +210,7 @@ checkUserCredentials();
                 :tool-version="props.toolVersion"
                 :tool-credentials-definition="credentialsDefinition"
                 :user-tool-credentials="userCredentials"
+                @delete-credentials-group="onDeleteCredentialsGroup"
                 @save-credentials="onSavedCredentials" />
         </BModal>
     </div>
diff --git a/client/src/components/User/Credentials/ManageToolCredentials.vue b/client/src/components/User/Credentials/ManageToolCredentials.vue
index 0eb4c70c4039..51b1c639e2b7 100644
--- a/client/src/components/User/Credentials/ManageToolCredentials.vue
+++ b/client/src/components/User/Credentials/ManageToolCredentials.vue
@@ -28,6 +28,7 @@ const providedCredentials = ref<CreateSourceCredentialsPayload>(initializeCreden
 
 const emit = defineEmits<{
     (e: "save-credentials", credentials: CreateSourceCredentialsPayload): void;
+    (e: "delete-credentials-group", reference: string, groupName: string): void;
 }>();
 
 function saveCredentials() {
@@ -103,6 +104,14 @@ function onNewCredentialsSet(credential: ServiceCredentialPayload, newSet: Servi
     }
 }
 
+function onDeleteCredentialsGroup(reference: string, groupName: string) {
+    const credentialFound = providedCredentials.value.credentials.find((c) => c.reference === reference);
+    if (credentialFound) {
+        credentialFound.groups = credentialFound.groups.filter((g) => g.name !== groupName);
+        emit("delete-credentials-group", reference, groupName);
+    }
+}
+
 function onCurrentSetChange(credential: ServiceCredentialPayload, newSet: ServiceGroupPayload) {
     const credentialFound = providedCredentials.value.credentials.find((c) => c.reference === credential.reference);
     if (credentialFound) {
@@ -133,6 +142,7 @@ function getServiceCredentialsDefinition(reference: string): ServiceCredentialsD
             :credential-payload="credential"
             class="mb-2"
             @new-credentials-set="onNewCredentialsSet"
+            @delete-credentials-group="onDeleteCredentialsGroup"
             @update-current-set="onCurrentSetChange" />
         <button class="btn-primary" @click="saveCredentials">Save Credentials</button>
     </div>
diff --git a/client/src/components/User/Credentials/ServiceCredentials.vue b/client/src/components/User/Credentials/ServiceCredentials.vue
index 25e662bfcae9..6528d8becebf 100644
--- a/client/src/components/User/Credentials/ServiceCredentials.vue
+++ b/client/src/components/User/Credentials/ServiceCredentials.vue
@@ -1,4 +1,6 @@
 <script setup lang="ts">
+import { faTrash } from "@fortawesome/free-solid-svg-icons";
+import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome";
 import { BBadge, BCard } from "bootstrap-vue";
 import { computed, ref } from "vue";
 import Multiselect from "vue-multiselect";
@@ -24,19 +26,27 @@ const props = defineProps<Props>();
 const selectedSet = ref<ServiceGroupPayload | undefined>(
     props.credentialPayload.groups.find((group) => group.name === props.credentialPayload.current_group)
 );
-const availableSets = computed<ServiceGroupPayload[]>(() => Object.values(props.credentialPayload.groups));
+
+const isAddingNewSet = ref(false);
+
 const newSetName = ref<string>("");
+
+const availableSets = computed<ServiceGroupPayload[]>(() => Object.values(props.credentialPayload.groups));
+
 const canCreateNewSet = computed<boolean>(
     () => newSetName.value.trim() !== "" && !availableSets.value.some((set) => set.name === newSetName.value)
 );
+
 const canShowSetSelector = computed<boolean>(
     () => props.credentialDefinition.multiple && availableSets.value.length > 1
 );
-const isAddingNewSet = ref(false);
+
+const canDeleteSet = computed<boolean>(() => selectedSet.value?.name !== "default");
 
 const emit = defineEmits<{
     (e: "new-credentials-set", credential: ServiceCredentialPayload, newSet: ServiceGroupPayload): void;
     (e: "update-current-set", credential: ServiceCredentialPayload, newSet: ServiceGroupPayload): void;
+    (e: "delete-credentials-group", reference: string, groupName: string): void;
 }>();
 
 function onAddingNewSet() {
@@ -92,6 +102,19 @@ function getVariableTitle(name: string, type: CredentialType): string {
 function getVariableDescription(name: string, type: CredentialType): string | undefined {
     return getVariableDefinition(name, type).description;
 }
+
+function onDeleteGroup() {
+    if (selectedSet.value) {
+        //TODO: Implement confirmation dialog.
+        const groupNameToDelete = selectedSet.value.name;
+        const defaultSet = availableSets.value.find((set) => set.name === "default");
+        if (defaultSet) {
+            selectedSet.value = defaultSet;
+            onCurrentSetChange(defaultSet);
+        }
+        emit("delete-credentials-group", props.credentialPayload.reference, groupNameToDelete);
+    }
+}
 </script>
 
 <template>
@@ -123,7 +146,7 @@ function getVariableDescription(name: string, type: CredentialType): string | un
             </h3>
             <p>{{ credentialDefinition.description }}</p>
             <div v-if="selectedSet">
-                <div v-if="canShowSetSelector">
+                <div v-if="canShowSetSelector" class="set-selection-bar">
                     <b>Using set:</b>
                     <Multiselect
                         v-model="selectedSet"
@@ -134,6 +157,14 @@ function getVariableDescription(name: string, type: CredentialType): string | un
                         track-by="name"
                         label="name"
                         @select="onCurrentSetChange" />
+                    <button
+                        v-if="canDeleteSet"
+                        size="sm"
+                        class="mx-2"
+                        title="Delete this set of credentials."
+                        @click="onDeleteGroup">
+                        <FontAwesomeIcon :icon="faTrash" />
+                    </button>
                 </div>
 
                 <div v-for="variable in selectedSet.variables" :key="variable.name">
@@ -198,4 +229,10 @@ function getVariableDescription(name: string, type: CredentialType): string | un
     gap: 1em;
     align-items: center;
 }
+.set-selection-bar {
+    display: grid;
+    grid-template-columns: auto 1fr auto;
+    align-items: center;
+    gap: 1em;
+}
 </style>
diff --git a/client/src/stores/userCredentials.ts b/client/src/stores/userCredentials.ts
index 5aadfde978c5..9974edf8dc3f 100644
--- a/client/src/stores/userCredentials.ts
+++ b/client/src/stores/userCredentials.ts
@@ -66,6 +66,43 @@ export const useUserCredentialsStore = defineScopedStore("userCredentialsStore",
         return data;
     }
 
+    async function deleteCredentialsGroupForTool(toolId: string, reference: string, groupName: string): Promise<void> {
+        const userId = ensureUserIsRegistered();
+        const key = getKey(toolId);
+        const credentials = userCredentialsForTools.value[key];
+
+        if (credentials) {
+            const serviceCredentials = credentials.find((credential) => credential.reference === reference);
+            if (!serviceCredentials) {
+                throw new Error(`No credentials found for reference ${reference}`);
+            }
+            const group = serviceCredentials.groups[groupName];
+            if (!group) {
+                throw new Error(`No group found for name ${groupName}`);
+            }
+            const { error } = await GalaxyApi().DELETE(
+                "/api/users/{user_id}/credentials/{user_credentials_id}/{group_id}",
+                {
+                    params: {
+                        path: { user_id: userId, user_credentials_id: serviceCredentials.id, group_id: group.id },
+                    },
+                }
+            );
+
+            if (error) {
+                throw Error(`Failed to delete user credentials group for tool ${toolId}: ${error.err_msg}`);
+            }
+            // Remove the group from the credentials
+            const updatedCredentials = credentials.map((credential) => {
+                if (credential.id === reference) {
+                    delete credential.groups[groupName];
+                }
+                return credential;
+            });
+            set(userCredentialsForTools.value, key, updatedCredentials);
+        }
+    }
+
     function ensureUserIsRegistered(): string {
         if (currentUserId === "anonymous") {
             throw new Error("Only registered users can have tool credentials");
@@ -89,5 +126,6 @@ export const useUserCredentialsStore = defineScopedStore("userCredentialsStore",
         getAllUserCredentialsForTool,
         fetchAllUserCredentialsForTool,
         saveUserCredentialsForTool,
+        deleteCredentialsGroupForTool,
     };
 });