From 09c2fef19094d39f5ae124fce5d7e341de56032e Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Tue, 7 Nov 2023 18:16:59 +0100 Subject: [PATCH] Fix output addition to history if input name is same as output name CWL output names are namespaced, so in that case the previous check doesn't work. --- lib/galaxy/tools/actions/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/galaxy/tools/actions/__init__.py b/lib/galaxy/tools/actions/__init__.py index dc1a8f699db5..50563eb55bcf 100644 --- a/lib/galaxy/tools/actions/__init__.py +++ b/lib/galaxy/tools/actions/__init__.py @@ -699,7 +699,7 @@ def handle_output(name, output, hidden=None): ) # Add all the top-level (non-child) datasets to the history unless otherwise specified for name, data in out_data.items(): - if name not in incoming and name not in child_dataset_names: + if getattr(data, "hid", None) is None or (name not in incoming and name not in child_dataset_names): # don't add already existing datasets, i.e. async created history.stage_addition(data) history.add_pending_items(set_output_hid=set_output_hid)