Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support save actions/org.eclipse.jst.ui.prefs #85

Open
cghislai opened this issue Sep 12, 2016 · 2 comments
Open

Support save actions/org.eclipse.jst.ui.prefs #85

cghislai opened this issue Sep 12, 2016 · 2 comments

Comments

@cghislai
Copy link

This file contains additional save actions like:
sp_cleanup.make_local_variable_final=false
sp_cleanup.make_parameters_final=true
sp_cleanup.make_private_fields_final=true
sp_cleanup.make_type_abstract_if_missing_method=false

...

@markiewb
Copy link
Collaborator

This plugin only bundles the eclipse formatter. Those save actions are not part of the eclipse formatter. Those actions are refactorings and the code for that is not included in the embedded eclipse formatter engine, which I bundled.

I will not work on this issue. But I will accept pull-requests!

@markiewb markiewb changed the title Support org.eclipse.jst.ui.prefs Support save actions/org.eclipse.jst.ui.prefs Sep 12, 2016
@funfried
Copy link
Owner

funfried commented Dec 22, 2019

There is also an issue filed for this together with some further information in the formatter-maven-plugin: revelc/formatter-maven-plugin#97 (comment)
Unfortunately, it seems that the mentioned library has a lot of Eclipse dependencies which even some of them cannot be found in the maven repositories. It seems those actions are too deeply coupled with Eclipse itself.
If anyone has a solution for this, feel free to raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants