Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly report container size in bytes as int #48

Open
BenGalewsky opened this issue Mar 27, 2023 · 0 comments
Open

Correctly report container size in bytes as int #48

BenGalewsky opened this issue Mar 27, 2023 · 0 comments

Comments

@BenGalewsky
Copy link
Contributor

Kevin ran across container_size (in funcx-services/web-service/funcx_web_service/schemas/container.py, specified in ContainerBuildStatusUpdate):

class ContainerBuildStatusUpdate(BaseModel):
    ...
    container_size: float = Field(default=0.0, description="Container size in bytes")
    ...

That is, the description lists "bytes" as the unit, but the data type is listed as a float? Does that seem correct to you? I would rather expect that to be a non-negative integer, like:

    container_size: NonNegativeInt = Field(default=0, description="...")

But that matches the spec in the funcX Container Service code, which is, currently:

class CompletionSpec(BaseModel):
    ...
    container_size: float = 0
    ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant