Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash when i click textinput then i click btn to call authorize function #179

Open
hth190393 opened this issue Nov 23, 2017 · 7 comments

Comments

@hth190393
Copy link

hth190393 commented Nov 23, 2017

This is err:
screen shot 2017-11-23 at 10 17 34 am
Help me please!

@Winglonelion
Copy link

same here +1

@stonehippo
Copy link

I'm also seeing this crasher. It appears to occur if the textInput has been given focus and has a onChangeText callback set.

@Winglonelion
Copy link

one more note: I met this issues only in IOS, Android work fine

@stonehippo
Copy link

@Winglonelion are you using the version published in npm? I noticed that a PR to fix #188 was accepted, and it might be the resolution for this issue. I’m trying out the master branch today to confirm:

$ npm i fullstackreact/react-native-oauth#master --save

Note that you'll still need to patch the swapped if statement in OAuthManager.m (I think there are at least two open PRs for that, including #157)

@Winglonelion
Copy link

In my case, app only crash when vitual Keyboard exist: And i think it has been mention in React Native release Note 0.52.0

Fix a crash when keyboard is visible and bridge reload happens on iOS (d9c6585 by @fromcelticpark) .

I have not try RN 0.52.0 yet but i think it is my problem.

@stonehippo
Copy link

I've submitted #207 with a fix for this. Basically, the viewController needs to be presented on the main thread to prevent the crash once the keyboard has been displayed (such as when a TextInput component has been given focus).

@Winglonelion
Copy link

Winglonelion commented May 9, 2018

thanks, @stonehippo.
I will try this and report you soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants