Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with println #179

Open
jackkoenig opened this issue Nov 8, 2017 · 2 comments
Open

Issues with println #179

jackkoenig opened this issue Nov 8, 2017 · 2 comments

Comments

@jackkoenig
Copy link
Collaborator

It appears that println is changed to instead call logger.info. I think this is kind of problematic because it is unexpected and it also accepts String rather than Any so you have to explicitly call .toString on arguments to it.

I think we should just mess around with println and encourage people to use the logger when they need multiple levels of verbosity.

@chick
Copy link
Contributor

chick commented Nov 8, 2017

@jackkoenig
I agree, not even sure how it happened.
So should I just remove that statement.
All tests pass when it is removed.
I don't think this is an API breaking change since println's signature is more permissive

@jackkoenig
Copy link
Collaborator Author

Yeah I agree, just removing the statement is the right move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants