Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clippy::default_trait_access from lint #2775

Open
ddoktorski opened this issue Dec 13, 2024 · 22 comments · May be fixed by #2875
Open

Remove clippy::default_trait_access from lint #2775

ddoktorski opened this issue Dec 13, 2024 · 22 comments · May be fixed by #2875
Assignees

Comments

@ddoktorski
Copy link
Contributor

ddoktorski commented Dec 13, 2024

Remove -A clippy::default_trait_access from the .cargo/config.toml and fix all warnings that occur after this change when running cargo lint.

After making this change, adjust the documentation in the development guide docs.

#2637 (comment)

@raizo07
Copy link

raizo07 commented Dec 17, 2024

I'd like to take this issue.

@GideonBature
Copy link

Can I try solving this issue?

My name is Gideon Bature, a Software Engineer having working experience with Rust.

From the description, I will remove -A clippy::default_trait_access from the .cargo/config.toml from the .cargo/config.toml and afterwards test the program to see which errors it's going to throw, from there I will start fixing the errors/warnings it's going to throw until we have a perfectly working program free from the warnings.

If assigned this issue, I will send my first PR within 48 hours. Thank you.

@pheobeayo
Copy link

I’d like to help with this.

@ryzen-xp
Copy link

Can I tackle this one?

@OWK50GA
Copy link

OWK50GA commented Dec 27, 2024

Can I take this issue?

@aidenwong812
Copy link

May I pick this up?

@emarc99
Copy link

emarc99 commented Jan 5, 2025

I’d like to help with this.

@ddoktorski ddoktorski added ODBoost and removed new labels Jan 16, 2025
@olisaagbafor
Copy link

I'd be happy to do this.

@cptartur cptartur moved this from New to Triage in Starknet foundry Jan 17, 2025
@cptartur cptartur moved this from Triage to Backlog in Starknet foundry Jan 17, 2025
@crood-xp
Copy link

Hi, I am proficient Blockchain developer expert in Cairo , Rust and Solidity and also in web development.
I have contributed many cairo ,rust projects like chainevents , arkprojects sunshine etc . please /assign this issue .
Thank You

@cptartur
Copy link
Member

Hey, this issue will be available for taking during the ODBoost https://app.onlydust.com/hackathons/odboost-1.
If you are still interested in tacking on this one, please apply after the ODBoost start tomorrow after 3 PM CET.

@wheval
Copy link

wheval commented Jan 21, 2025

Could I grab this task?

@ekumamatthew
Copy link

Mind if I try this one?

@dlaciport
Copy link
Contributor

Could I work on this issue? I have experience in Rust and the Starknet ecosystem.

@emarc99
Copy link

emarc99 commented Jan 22, 2025

I can do this with ETA of 2 days max.
I have relevant Rust experience.

@QuenumGerald
Copy link

Hi @ddoktorski,

I’m a developer with 10 years of experience, including expertise in Rust development and linting practices. I am confident in handling this task, which involves removing the -A clippy::default_trait_access configuration, fixing the resulting warnings, and updating the documentation accordingly.

I have a strong background in managing similar tasks and ensuring that all changes align with a project's standards. I would love to contribute to StarkNet Foundry!

@ussyalfaks
Copy link

Can I take this issue?

@GideonBature
Copy link

Can I try solving this issue?

My name is Gideon Bature, a Software Engineer having working experience with Rust.

From the description, I will remove -A clippy::default_trait_access from the .cargo/config.toml from the .cargo/config.toml and afterwards test the program to see which errors it's going to throw, from there I will start fixing the errors/warnings it's going to throw until we have a perfectly working program free from the warnings.

If assigned this issue, I will send my first PR within 48 hours. Thank you.

@coxmars
Copy link

coxmars commented Jan 22, 2025

I'm a software developer with 2+ years of experience and I have worked with backend technologies such as Cairo, Java, C# and frontend with React, NextJS, JS/TS. Also, I'm a member of the Dojo Coding community here in CR and I have made contributions in Cairo VM Go, Cairo VM TS, Cairo Lints etc. Likewise, I’m a Cairo developer working in ByteBuildersLabs creating on-chain games using the Dojo framework.

This is my approach:

  • Remove -A clippy::default_trait_access from .cargo/config.toml and run cargo lint to identify new warnings.
  • Fix identified warnings by replacing Default::default() calls with explicit type initializations and proper struct field initialization across the codebase.
  • Run comprehensive tests including cargo lint to verify warnings.
  • Update development guide documentation to reflect new linting requirements.
  • Submit PR with all changes and include before/after cargo lint outputs.

@guha-rahul
Copy link

I have been contributor the Reth codebase. I would be like to tackle this issue.

@BraCR10
Copy link

BraCR10 commented Jan 22, 2025

Hello, I'd like to take this issue. I'll remove the the command and look for warmings related with the traits access.

@1nonlypiece
Copy link

Application for Contribution

I am excited about the opportunity to contribute to this issue and am confident that my expertise aligns well with the requirements. With a strong background in Cairo programming and decentralized application development on StarkNet, I bring a well-rounded skill set to deliver an effective solution.

Relevant Expertise

  • Blockchain & Smart Contracts: Extensive experience with StarkNet, Stellar, and Rust, specializing in developing secure and optimized smart contracts, blockchain integrations, and high-performance backend infrastructure.
  • Backend Development: Well-versed in API design, server-side logic, and scalable system architecture, ensuring efficient and seamless backend performance.
  • Frontend Engineering: Skilled in crafting interactive and responsive UI components using React and Next.js, enhancing the user experience for blockchain-based platforms.

Why Consider My Application?

My proven track record of delivering high-quality, optimized solutions in blockchain and full-stack development sets me apart. I have a deep understanding of smart contract security, decentralized architectures, and the synergy between frontend, backend, and blockchain layers—ensuring a seamless and efficient implementation.

ETA

I expect to have a working solution ready within 48 hours. Please let me know if I can proceed with the implementation.

@MohamedAshiq09
Copy link

I’d like to work on this.

@ekumamatthew ekumamatthew linked a pull request Jan 24, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.