Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use a parameter named user_id #9

Closed
richrd opened this issue Jan 27, 2020 · 2 comments
Closed

Unable to use a parameter named user_id #9

richrd opened this issue Jan 27, 2020 · 2 comments

Comments

@richrd
Copy link

richrd commented Jan 27, 2020

Hi! Really neat project! I was trying this out and made a simple definition for looking up users by their id. Regardless of what user_id I supplied it always returned the user with ID 999. This seems to be causing it but I have no idea what that's for: https://github.com/forbesmyester/esqlate-server/blob/master/src/server.ts#L171

I can easily work around this by changing the parameter name but this did surprise me a bit 🙂

@forbesmyester
Copy link
Owner

Hi, thanks for your interest, people finding stupid bugs like this warms my heart because I can see that people are actually using it!

This code currently serves no purpose. It's left over really early code from when I was thinking about variables coming from different places, maybe as environmental variables or something else.

I'm in the middle of working on #4 and will come back to this over the next week or so if you could work around it for the time being that'd be great :-)

@richrd
Copy link
Author

richrd commented Feb 4, 2020

This was a rather fun bug to find, a genuine WTF moment 😄 Really nice hear #4 getting some attention. I can easily work around this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants