flameshot gui exits with 0 on abort

[cyqsimon]

Flameshot Version

Flameshot v12.1.0 (-)
Compiled with Qt 5.15.5

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

EndeavourOS, Linux 6.4.12-arch1-1 x86_64

Description

I was trying to use flameshot in scripting, and was surprised to find that flameshot gui does not exit with non-zero status when user aborts. This makes scripting quite a bit more annoying.

The behaviour I expected is to exit with 1 (or whatever) on abort.

Steps to reproduce

1. Run flameshot gui in terminal
2. Hit esc to abort
3. Run echo $?, notice that the status is 0

Screenshots or screen recordings

No response

System Information

Operating System: EndeavourOS
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.10
Kernel Version: 6.4.12-arch1-1 (64-bit)
Graphics Platform: X11

[muzilong]

same problem

[Monirzadeh]

if i use std::exit(1); to bellow part problem can be solve.

flameshot/src/main.cpp

Lines 65 to 68 in 3d21e49

	QObject::connect(flameshot, &Flameshot::captureFailed, []() {
	AbstractLogger::info() << "Screenshot aborted.";
	qApp->exit(1);
	});

is there any specific reason that i should avoid that and force us to use qApp->exit(1);?

[serebryakov02]

Question for the developers: How can I run Flameshot from the terminal using the source code? When I launch it from Qt Creator and follow the instructions, I do not receive any messages. However, if I download Flameshot as a standalone program and launch it according to the instructions, I can reproduce.

[Monirzadeh]

you should follow this guide than run flameshot in build directory

[guyueshui]

Since this issue is marked as "Good first issue" by member of flameshot, and I've used flameshot for quite a while and am happy to make some contributions if possible. So I tried read the code and found this simple solution, hope it helps.

Please let me know if I was wrong, this is my first pull request (#3786) on my life though.