Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canmesage.py: Bugs in decoding msg payload in from_string method. #12

Open
jpyka opened this issue Sep 9, 2020 · 0 comments · May be fixed by #17
Open

canmesage.py: Bugs in decoding msg payload in from_string method. #12

jpyka opened this issue Sep 9, 2020 · 0 comments · May be fixed by #17

Comments

@jpyka
Copy link

jpyka commented Sep 9, 2020

  1. Index shift takes into account only message id and not the dlc.
  2. Payload byte should be referenced like this: msg[index: index + 2] and not msg[index: index + 1].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant