Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the profile time range in the profile, rather than computing it based on samples / markers #5300

Open
mstange opened this issue Jan 10, 2025 · 0 comments
Labels
profile data Issues related to the profile format, data structure, or profile upgraders timeline Issues related to the header timeline view

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

When we load a profile, we compute the visible start and end time based on the sample and marker data in the profile.
It would be faster and less brittle to skip this computation.

I would say that, in all cases, the tool which creates the profile knows best for which time range it has data. So it should write that time range down in the profile.

This would also simplify our code, because we don't need to worry about caching the computed time range efficiently.
And it would fix bugs where the automatic computation gives bad results, such as #4129.
It would also make it easier to fix bugs in the uploading sanitizer, like #3518 and #3279.

┆Issue is synchronized with this Jira Task

@canova canova added timeline Issues related to the header timeline view profile data Issues related to the profile format, data structure, or profile upgraders labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profile data Issues related to the profile format, data structure, or profile upgraders timeline Issues related to the header timeline view
Projects
None yet
Development

No branches or pull requests

2 participants