diff --git a/.github/workflows/integration_tests.yml b/.github/workflows/integration_tests.yml index 5959a48651..618c02bcc8 100644 --- a/.github/workflows/integration_tests.yml +++ b/.github/workflows/integration_tests.yml @@ -772,7 +772,12 @@ jobs: shell: bash timeout_minutes: 5 max_attempts: 3 - command: npm install -g firebase-tools + command: npm install firebase-tools + - name: Add firebase-tools to PATH + shell: bash + run: | + echo "$(npm root)" >> $GITHUB_PATH + echo "$(npm root)/.bin" >> $GITHUB_PATH - name: Setup java uses: actions/setup-java@v3 with: @@ -1166,7 +1171,13 @@ jobs: shell: bash timeout_minutes: 5 max_attempts: 3 - command: npm install -g firebase-tools + command: npm install firebase-tools + - name: Add firebase-tools to PATH + if: contains(needs.check_and_prepare.outputs.apis, 'firestore') + shell: bash + run: | + echo "$(npm root)" >> $GITHUB_PATH + echo "$(npm root)/.bin" >> $GITHUB_PATH - name: Start Firestore Emulator if: steps.device-info.outputs.device_type == 'virtual' && contains(needs.check_and_prepare.outputs.apis, 'firestore') run: | @@ -1287,7 +1298,13 @@ jobs: shell: bash timeout_minutes: 5 max_attempts: 3 - command: npm install -g firebase-tools + command: npm install firebase-tools + - name: Add firebase-tools to PATH + if: contains(needs.check_and_prepare.outputs.apis, 'firestore') + shell: bash + run: | + echo "$(npm root)" >> $GITHUB_PATH + echo "$(npm root)/.bin" >> $GITHUB_PATH - name: Start Firestore Emulator if: contains(needs.check_and_prepare.outputs.apis, 'firestore') run: | diff --git a/gma/integration_test/src/integration_test.cc b/gma/integration_test/src/integration_test.cc index 8b12ae74e3..0ecf5cd7de 100644 --- a/gma/integration_test/src/integration_test.cc +++ b/gma/integration_test/src/integration_test.cc @@ -3057,18 +3057,6 @@ TEST_F(FirebaseGmaUmpTest, TestUmpMethodsReturnOperationInProgress) { future_request_2, "RequestConsentInfoUpdate second", firebase::gma::ump::kConsentRequestErrorOperationInProgress); WaitForCompletion(future_request_1, "RequestConsentInfoUpdate first"); - - firebase::Future future_load_and_show_1 = - consent_info_->LoadAndShowConsentFormIfRequired( - app_framework::GetWindowController()); - firebase::Future future_load_and_show_2 = - consent_info_->LoadAndShowConsentFormIfRequired( - app_framework::GetWindowController()); - WaitForCompletion(future_load_and_show_2, - "LoadAndShowConsentFormIfRequired second", - firebase::gma::ump::kConsentFormErrorOperationInProgress); - WaitForCompletion(future_load_and_show_1, - "LoadAndShowConsentFormIfRequired first"); } TEST_F(FirebaseGmaUmpTest, TestUmpMethodsReturnOperationInProgressWithUI) { diff --git a/gma/src/include/firebase/gma/ump/consent_info.h b/gma/src/include/firebase/gma/ump/consent_info.h index 439a0b7abb..8f69918ed0 100644 --- a/gma/src/include/firebase/gma/ump/consent_info.h +++ b/gma/src/include/firebase/gma/ump/consent_info.h @@ -76,7 +76,10 @@ class ConsentInfo { /// @code /// #if defined(__ANDROID__) /// consent_info = firebase::gma::ump::ConsentInfo::GetInstance(jni_env, - /// activity); #else consent_info = firebase::gma::ump::GetInstance(); #endif + /// activity); + /// #else + /// consent_info = firebase::gma::ump::GetInstance(); + /// #endif /// @endcode /// /// @param[in] jni_env JNIEnv pointer.