Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing the component the control stays behind #15

Open
Esurnir opened this issue Jan 27, 2020 · 3 comments
Open

When removing the component the control stays behind #15

Esurnir opened this issue Jan 27, 2020 · 3 comments

Comments

@Esurnir
Copy link

Esurnir commented Jan 27, 2020

Hello everyone.

So when I did a simple test like

<v-map :zoom=3 :center="location">
  <v-tilelayer url="http://{s}.tile.osm.org/{z}/{x}/{y}.png"></v-tilelayer>
  <v-geosearch v-if="booleanHere" :options="geosearchOptions" ></v-geosearch>
</v-map>

And I switched booleanHere true and false multiple times I get multiple geosearch controls being created but not deleted. I assume this is because we do add control during the mounting step but do not remove it during the beforeDestroy. I am going to make a pull request soon that I believe would solve the problem. (and it's my first time attempting to contribute to an open-source software so I took it as a bit of training in how to make a pull request).

@fega
Copy link
Owner

fega commented Jan 27, 2020

@Esurnir could you provide me a way to test your changes?

@Esurnir
Copy link
Author

Esurnir commented Jan 28, 2020

This small demo should provide a test case.
demo-pr.zip

@yurixcode
Copy link

I am having this same problem, has it been resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants