You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From there I resumed work trying to figure out how to make the navigation drawer stay open, or at least close more gracefully, on page transitions. This opened up a whole can of worms regarding how the navigation is structured, such as how the navigation of a particular project’s documentation relates to the overall navigation for the site in general. Right now, it’s hard to to really anticipate what this should look like, since it won’t really be an issue until we’re using more than one source repository. But there are unavoidable knock-on effects which seem important to consider now, namely how do we aggregate and structure the data from the source repositories and parcel out portions of that data to the pages that need it. I’ve got a WIP branch started, but I’m probably going to shelve that for now, so I don’t have to deal with that can of worms just yet.
There are a lot of hairy details in this, but I'll definitely need to add a gatsby-browser.js file, and I probably want to consolidate some of the configuration for the source repos in gatsby-config.js, and streamline how that config is queried in gatsby-node.js. I may be able to resolve this w/o totally overhauling everything, so I might revisit it sooner than later, just not going to let myself get bogged down or blocked by this before putting this into production.
The text was updated successfully, but these errors were encountered:
Ok, so I took another stab at this. I ripped out practically everything from docs-page.js and moved it all to layout.js, which is now being rendered in wrapPageElement in gatsby-browser.js. Not everything is perfectly resolved but I think I've actually got a pretty good overall system in place now, with source-repos.js being the main source of truth now for all details regarding the source repos. It's an improvement, for sure.
I'd still like to handle drawer clicks better, so the drawer closes after you click on a menu item, but I think I can bang that out when I do #2 next. The main issue here though is addressed, so I'm closing it.
I'm punting on this for now, but it would be good to work on how the nav drawer closes after you click on one of its links.
As I mentioned on the forum:
There are a lot of hairy details in this, but I'll definitely need to add a
gatsby-browser.js
file, and I probably want to consolidate some of the configuration for the source repos ingatsby-config.js
, and streamline how that config is queried ingatsby-node.js
. I may be able to resolve this w/o totally overhauling everything, so I might revisit it sooner than later, just not going to let myself get bogged down or blocked by this before putting this into production.The text was updated successfully, but these errors were encountered: