-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render a link to source repo #21
Comments
Yes! Great idea!
Totally. 💯 I really don't think it belongs in the source repos. If nothing else it's totally unnecessary if someone is already viewing the content in GitHub. Also, what if the repository is cloned to GitLab, or some private git server? What if someone forks the repo and wants to host the docs on a different website, with different links to that fork? Links like ought to be the responsibility of the publisher, imo.
Yep! Should be pretty straightforward. When referencing that configuration, I've actually opted to store it all as JSON in the Hardcoding that file path isn't quite ideal, cuz I don't know if I'll need to change it in the future, but our current Webpack/Gatsby version only supports "static specifiers" for dynamic imports (ie, an actual string as the argument, not a template literal or variable). In the meantime, we can try to limit how often that's used, and if we need it in other components, we can just pass it down as props. |
Just posted this in #24:
@paul121, this may mean we don't need #22 for the links to the source repos themselves, but I would still like to use what you've done there for adding the "Edit this page on GitHub" button. I'm also backtracking a little on my earlier comment above:
I still don't think it is good to include links like that in the Markdown, but I think it makes perfect sense in the So for the farmOS.js nav:
- Getting started: index.md
- Schemata: schemata.md
- Remotes: remotes.md
- Entities: entities.md
- Metadata: metadata.md
- API reference: api.md
- Source: https://github.com/farmOS/farmOS.js Then something like the What do you think? |
Not the final solution, but a first step PR: #63 |
Currently farmOS.js / farmOS.py and even farmOS don't have a link back to their respective github repos. They could add it themselves, but perhaps it would be better to add a nice little Github icon + link in this repo itself. Ideally we could pull the url from the source repo config?
The text was updated successfully, but these errors were encountered: