Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensor object should only be accessible by doing import or require #12

Open
yxliang01 opened this issue Oct 11, 2017 · 0 comments
Open

Sensor object should only be accessible by doing import or require #12

yxliang01 opened this issue Oct 11, 2017 · 0 comments

Comments

@yxliang01
Copy link
Contributor

yxliang01 commented Oct 11, 2017 •
edited
Loading

Sensor object should only be accessible by doing import or require, instead of putting it to the global window object. I believe this is a better practice. Also, when you do testing, the global object sensors will just simply not exist.

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yxliang01