You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These should all be only used by op.c, so you can modify them if you like. They should be replaced with static inline functions with the name lower cased. There should be no need to put them into embed.fnc.
But as @johndeppe pointed out, IS_AND_OP(op) and IS_OR_OP(op) are just OP_TYPE_IS_NN(op, OP_AND) and OP_TYPE_IS_NN(op, OP_OR). They're used very infrequently, they're poorly documented, so it's better to delete them and use OP_TYPE_IS_NN().
Candidates include...
These should all be only used by op.c, so you can modify them if you like. They should be replaced with
static inline
functions with the name lower cased. There should be no need to put them intoembed.fnc
.For example...
Becomes...
But as @johndeppe pointed out,
IS_AND_OP(op)
andIS_OR_OP(op)
are justOP_TYPE_IS_NN(op, OP_AND)
andOP_TYPE_IS_NN(op, OP_OR)
. They're used very infrequently, they're poorly documented, so it's better to delete them and useOP_TYPE_IS_NN()
.Remember to...
static
.grep -r MACRO_NAME
to make sure nothing else is using it.static inline
and the name lower cased.#define IS_AND_OP(o)
becomesstatic inline is_and_op(OP *o)
You don't have to do them all to make a pull request.
The text was updated successfully, but these errors were encountered: