Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont work with python 3.8 #44

Open
drewer opened this issue Jul 22, 2021 · 9 comments
Open

dont work with python 3.8 #44

drewer opened this issue Jul 22, 2021 · 9 comments

Comments

@drewer
Copy link

drewer commented Jul 22, 2021

module 're' has no attribute '_pattern_type'

@marrold
Copy link

marrold commented Jul 24, 2021

I just encountered this issue. Looks like its fixed in the master but not in the pip package

@ettoreleandrotognoli
Copy link
Owner

Yeah, it looks like that I forgot to release this fix

@ettoreleandrotognoli
Copy link
Owner

https://pypi.org/project/asterisk-ami/0.1.6/

@marrold
Copy link

marrold commented Jul 24, 2021

Just a heads up, there might be a bug in the latest release. The AMI is disconnecting but If I roll back to the previous release it works fine.

Something is firing the disconnect here -

self._fire_on_disconnect(error=None)

I will try and troubleshoot some more tomorrow

Thanks!

@marrold
Copy link

marrold commented Jul 24, 2021

Replicated with this simple script taken from the example - https://gist.github.com/marrold/8c4cf1b7c89dc3935626f5ab85d4cd0f

After a few seconds I get The AMI has disconnected: None

Looking at the actual messages to the AMI, it randomly tries to login in again despite a ping response, then finally gives up - https://gist.github.com/marrold/652ca6afc0a1d551332cdbff6cae2099

@marrold
Copy link

marrold commented Jul 24, 2021

I reverted this commit and now it works - 8bed899

But unfortunatly I don't know why that's causing the issue.

@jowrjowr do you recall why you made this change? Do you know why it would cause this issue? Thanks!

@jowrjowr
Copy link
Contributor

All I can remember is what I put in as the commit reason, and that seems pretty self-explanatory.

As I recall, connections would time out but never fail and that was causing issues with some scripting around a client's Asterisk I was working with at the time. Haven't touched this stuff since so I have no recent insight.

@marrold
Copy link

marrold commented Jul 24, 2021

Okay, thanks for the info

@marrold
Copy link

marrold commented Jul 25, 2021

I think this might be an issue on my side, I'll continue to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants