Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Excessive Space Between Navbar and Ethereum-Powered Tools and Services Banner #11730

Closed
1 of 2 tasks
piyushbarve98 opened this issue Nov 27, 2023 · 14 comments · Fixed by #13436
Closed
1 of 2 tasks
Assignees
Labels
bug 🐛 Something isn't working design All the issues related to design should use this tag Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@piyushbarve98
Copy link

Describe the bug

Excessive amount of space between the navbar and the "Ethereum-Powered Tools and Services" banner on dapps page. This issue affects the overall layout and visual cohesion of the webpage, we also have to scroll down to access explore dapps, and what are dapps button.

To reproduce

  1. Go to 'https://ethereum.org/en/dapps/' page
  2. Observe the space between the navbar and the "Ethereum-Powered Tools and Services" banner.

Expected behavior

The space between the navbar and the banner should be appropriately sized to maintain a visually balanced layout, and also can see the whole banner content without need to scroll.

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@piyushbarve98 piyushbarve98 added the bug 🐛 Something isn't working label Nov 27, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Nov 27, 2023
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 12, 2024
@WebSculptor
Copy link

I would love to work on this and if assigned i can finish it on the same day

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Apr 29, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 30, 2024
@Arika4ox
Copy link

Arika4ox commented May 30, 2024 via email

@github-actions github-actions bot removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 31, 2024
@wackerow
Copy link
Member

Thanks @piyushbarve98! Sorry for delay here.

@nloureiro Where are we at with the DS Hero rollout again? Is this something that is already in the pipeline?

@wackerow wackerow added question ❓ Further information is requested design All the issues related to design should use this tag and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 14, 2024
@wackerow
Copy link
Member

@nloureiro Assigning you in the interim, if this is something @piyushbarve98 can help contribute with please feel free to reassign

@nloureiro
Copy link
Contributor

To be honest, I need to double-check with @pettinarip and @TylerAPfledderer on this.

@TylerAPfledderer
Copy link
Contributor

@nloureiro there are currently multiple pages with this level of spacing, which comes from the current Pagehero Component.

Corwin did not include that component in #13043, by the way. I think this probably should be patched for now until these pages flip over to the new heroes.

@nloureiro
Copy link
Contributor

@nloureiro there are currently multiple pages with this level of spacing, which comes from the current Pagehero Component.

Corwin did not include that component in #13043, by the way. I think this probably should be patched for now until these pages flip over to the new heroes.

ok, that makes sense.
@WebSculptor, are you still available to make the patch for this?

@TylerAPfledderer
Copy link
Contributor

@nloureiro there are currently multiple pages with this level of spacing, which comes from the current Pagehero Component.

Corwin did not include that component in #13043, by the way. I think this probably should be patched for now until these pages flip over to the new heroes.

ok, that makes sense.
@WebSculptor, are you still available to make the patch for this?

@nloureiro I believe the callout was meant for @piyushbarve98. 😁

Are you still available to contribute a PR for a patch to the PageHero?

@MahendraBishnoi29
Copy link
Contributor

should i fix this? if yes then assign to me @wackerow

@wackerow
Copy link
Member

wackerow commented Jul 1, 2024

Hey @MahendraBishnoi29, thanks for offering... Will go ahead and assign you since we haven't yet heard back yet from WebSculptor

@wackerow wackerow removed the question ❓ Further information is requested label Jul 1, 2024
@MahendraBishnoi29
Copy link
Contributor

Hey @MahendraBishnoi29, thanks for offering... Will go ahead and assign you since we haven't yet heard back yet from WebSculptor

thanks, raising a PR soon 💪🏻

Copy link
Contributor

github-actions bot commented Aug 1, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working design All the issues related to design should use this tag Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants