-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary Excessive Space Between Navbar and Ethereum-Powered Tools and Services Banner #11730
Comments
This issue is stale because it has been open 45 days with no activity. |
I would love to work on this and if assigned i can finish it on the same day |
This issue is stale because it has been open 30 days with no activity. |
Be my guest.
…On Thu, May 30, 2024, 1:06 AM github-actions[bot] ***@***.***> wrote:
This issue is stale because it has been open 30 days with no activity.
—
Reply to this email directly, view it on GitHub
<#11730 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKEAL3YFVFJGHVK3WDAUKL3ZE3MXBAVCNFSM6AAAAAA74QTKLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYHEZDSMBTGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thanks @piyushbarve98! Sorry for delay here. @nloureiro Where are we at with the DS Hero rollout again? Is this something that is already in the pipeline? |
@nloureiro Assigning you in the interim, if this is something @piyushbarve98 can help contribute with please feel free to reassign |
To be honest, I need to double-check with @pettinarip and @TylerAPfledderer on this. |
@nloureiro there are currently multiple pages with this level of spacing, which comes from the current Pagehero Component. Corwin did not include that component in #13043, by the way. I think this probably should be patched for now until these pages flip over to the new heroes. |
ok, that makes sense. |
@nloureiro I believe the callout was meant for @piyushbarve98. 😁 Are you still available to contribute a PR for a patch to the |
should i fix this? if yes then assign to me @wackerow |
Hey @MahendraBishnoi29, thanks for offering... Will go ahead and assign you since we haven't yet heard back yet from WebSculptor |
thanks, raising a PR soon 💪🏻 |
This issue is stale because it has been open 30 days with no activity. |
Describe the bug
Excessive amount of space between the navbar and the "Ethereum-Powered Tools and Services" banner on dapps page. This issue affects the overall layout and visual cohesion of the webpage, we also have to scroll down to access explore dapps, and what are dapps button.
To reproduce
Expected behavior
The space between the navbar and the banner should be appropriately sized to maintain a visually balanced layout, and also can see the whole banner content without need to scroll.
Screenshots
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: