rebar3 new ct-suite

[tsloughter]

A common test suite template would be useful. Like:

rebar3 new ct-suite modname

Creates the file test/modname_SUITE.erl:

-module(modname_SUITE).

-compile(export_all).

-include_lib("common_test/include/ct.hrl").
-include_lib("stdlib/include/assert.hrl").

all() ->
  [].

init_per_suite(Config) ->
  Config.

end_per_suite...

init_per_group..

end_per_group..

init_per_testcase...

end_per_testcase...

[max-au]

Funny enough, I have exactly this template done (did PR just now).

I'd also suggest to add gen_server, supervisor (there is one for "rebar3 new app", but it's worth having it separated), and gen_statem.

[ferd]

We should figure out what we want to keep between #2070 and #2072

[max-au]

I was waiting for this one - https://github.com/erlang/rebar3/pull/2070/files#r282486325 - to be resolved.

I don't have a strong opinion, except for -export_all controversy. This may trigger "broken window theory" - if code has one warning suppressed, it is quite tempting to suppress more and more, and end up with removing the warning altogether.

[ferd]

I'll wait for @tsloughter for the comment you mentioned. OTOH for the -export_all I generally like it, but I think it could make sense to use -compile([export_all, nowarn_export_all]) in the template only so that it does not turn off the warning for regular modules, only for the CT test suite we know may export dozens of cases. I don't recall if you found that to be too lax as well (or if it risked causing issues on older OTP versions)

[tsloughter]

I failed to add that feature :(. One of my attempts was https://github.com/erlang/rebar3/pull/2076/files

I also tried using expand_path for the variable substitution.

Kind of annoying, we actually do this in the relx overlays.. All the templating really should be consolidated, it is a mess.

[tsloughter]

But also, the thing I have the strongest opinion on is that export_all is used, hehe. But agree it makes sense to use -compile([export_all, nowarn_export_all]) instead of putting it in the profile.