Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person components don't have custom image when using custom data #854

Open
AndrejNikolicEq opened this issue Sep 21, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@AndrejNikolicEq
Copy link
Contributor

AndrejNikolicEq commented Sep 21, 2023

When using custom data for Person Components, you can't add and use custom images.

PersonAvatar dataSource type is AvatarData
PersonCard dataSource type is CardData

export type AvatarData = Pick<PersonInfo, 'name' | 'accountType'>;
export type CardData = PersonDetails;

export type PersonInfo = {
    azureId: string;
    name?: string;
    jobTitle?: string;
    department?: string;
    mail?: string;
    mobilePhone?: string;
    accountType?: PersonAccountType;
    officeLocation?: string;
    managerAzureUniqueId?: string;
};
export type PersonDetails = PersonInfo & {
    positions?: Position[];
    manager?: Manager;
};

PersonDetails and PersonInfo don't have pictureSrc

@AndrejNikolicEq AndrejNikolicEq added the bug Something isn't working label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant